-
Notifications
You must be signed in to change notification settings - Fork 31
🔥 remove auto-marked xfail for fp8, include fp8 tests by default, add xfail manually #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to vLLM support on Spyre. Or this can be done with Now you are good to go 🚀 |
|
bot:test |
|
@prashantgupta24 I see we also still have If we're confident in the fp8 tests (except the ones manually marked xfail here) then it may be less confusing to have them all run by default. We would have to update our |
Trying now... |
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
acf6f5d to
18e12d6
Compare
Signed-off-by: Prashant Gupta <[email protected]>
wallashss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LPGTM thanks!
|
bot:test |
|
bot:test |
1 similar comment
|
bot:test |
Description
Fp8 should now be fully supported (almost). Some tests are failing due to output mismatch, those are marked
xfailmanually.Related PRs
fix: static batching with FP8 - #457
and
fix: tests for graph comparison with FP8 - #462