Skip to content

Conversation

@prashantgupta24
Copy link
Collaborator

@prashantgupta24 prashantgupta24 commented Sep 29, 2025

Description

Fp8 should now be fully supported (almost). Some tests are failing due to output mismatch, those are marked xfail manually.

Related PRs

fix: static batching with FP8 - #457
and
fix: tests for graph comparison with FP8 - #462

@github-actions
Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@prashantgupta24 prashantgupta24 changed the title 🔥 remove xfail for fp8 🔥 remove auto-marked xfail for fp8, add xfail manually Sep 29, 2025
@maxdebayser
Copy link
Collaborator

bot:test

@joerunde
Copy link
Collaborator

@prashantgupta24 I see we also still have _skip_quantized_by_default- do you think it's time to remove that too?

If we're confident in the fp8 tests (except the ones manually marked xfail here) then it may be less confusing to have them all run by default. We would have to update our pytest invocations though to e.g. skip fp8 on most of the test matrix here in GHA since the cpus are too slow to run the fp8 models

@prashantgupta24
Copy link
Collaborator Author

prashantgupta24 commented Sep 30, 2025

@prashantgupta24 I see we also still have _skip_quantized_by_default- do you think it's time to remove that too?

If we're confident in the fp8 tests (except the ones manually marked xfail here) then it may be less confusing to have them all run by default. We would have to update our pytest invocations though to e.g. skip fp8 on most of the test matrix here in GHA since the cpus are too slow to run the fp8 models

Trying now...

Signed-off-by: Prashant Gupta <[email protected]>
Copy link
Collaborator

@wallashss wallashss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LPGTM thanks!

@prashantgupta24
Copy link
Collaborator Author

bot:test

@prashantgupta24
Copy link
Collaborator Author

bot:test

1 similar comment
@prashantgupta24
Copy link
Collaborator Author

bot:test

@prashantgupta24 prashantgupta24 changed the title 🔥 remove auto-marked xfail for fp8, add xfail manually 🔥 remove auto-marked xfail for fp8, include fp8 tests by default, add xfail manually Oct 1, 2025
@prashantgupta24 prashantgupta24 enabled auto-merge (squash) October 1, 2025 19:34
@github-actions github-actions bot added the ready Runs the full CI test suite. Only add to PRs once ready to merge to limit public GHA usage label Oct 1, 2025
@prashantgupta24 prashantgupta24 merged commit 71f34a3 into main Oct 1, 2025
30 of 39 checks passed
@prashantgupta24 prashantgupta24 deleted the remove-xfail-fp8 branch October 1, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Runs the full CI test suite. Only add to PRs once ready to merge to limit public GHA usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants