fix: static batching with FP8 #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wallas Santos <[email protected]>
wallashss
requested review from
nikolaospapandreou,
sducouedic,
tdoublep and
yannicks1
as code owners
|
👋 Hi! Thank you for contributing to vLLM support on Spyre. Or this can be done with Now you are good to go 🚀 |
Collaborator
Author
|
bot:test |
joerunde
approved these changes
Sep 11, 2025
Collaborator
joerunde
left a comment
joerunde
left a comment
There was a problem hiding this comment.
manually validated on spyre, lgtm!
yannicks1
added a commit
that referenced
this pull request
Sep 12, 2025
### [fp8] fix tests: increase ISCLOSE_ABS_TOL_QUANTIZATION post #457 test_spyre_basic.py::test_output fp8 tests were failing. This PR increases the `ISCLOSE_ABS_TOL_QUANTIZATION` to have the test passing again. --------- Signed-off-by: Yannick Schnider <[email protected]>
prashantgupta24
added a commit
that referenced
this pull request
Oct 1, 2025
# Description Fp8 should now be fully supported (almost). Some tests are failing due to output mismatch, those are marked `xfail` manually. ## Related PRs fix: static batching with FP8 - #457 and fix: tests for graph comparison with FP8 - #462 --------- Signed-off-by: Prashant Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes FP8 with static batching was hardcoded
Related Issues