Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions tests/entrypoints/openai_api/test_serving_chat_sampling_params.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,13 @@ def mock_request():
# OpenAI standard sampling fields
request.temperature = None
request.top_p = None
request.top_k = None
request.max_tokens = None
request.min_tokens = None
request.seed = None
request.ignore_eos = None
request.stop = None
request.stop_token_ids = None
request.frequency_penalty = None
request.presence_penalty = None
return request
Expand All @@ -106,9 +110,13 @@ def test_openai_sampling_fields_contains_expected_fields():
expected_fields = {
"temperature",
"top_p",
"top_k",
"max_tokens",
"min_tokens",
"seed",
"ignore_eos",
"stop",
"stop_token_ids",
"frequency_penalty",
"presence_penalty",
}
Expand Down Expand Up @@ -236,20 +244,6 @@ def test_multiple_params_override_together(serving_chat, mock_request):
assert comprehension_params.repetition_penalty == 1.05


def test_yaml_custom_params_not_overridden_by_request(serving_chat, mock_request):
"""Test that YAML custom params (top_k, repetition_penalty) are not affected."""
# Even if request has these attributes, they should not override YAML
# because they're not in _OPENAI_SAMPLING_FIELDS
mock_request.top_k = 100 # Not in allowlist
mock_request.repetition_penalty = 2.0 # Not in allowlist

result = serving_chat._build_sampling_params_list_from_request(mock_request)

comprehension_params = result[0]
assert comprehension_params.top_k == 1 # YAML default preserved
assert comprehension_params.repetition_penalty == 1.05 # YAML default preserved


# =============================================================================
# Tests for _apply_request_overrides
# =============================================================================
Expand Down
4 changes: 4 additions & 0 deletions vllm_omni/entrypoints/openai/serving_chat.py
Original file line number Diff line number Diff line change
Expand Up @@ -489,9 +489,13 @@ def _get_comprehension_stage_index(self) -> int:
_OPENAI_SAMPLING_FIELDS: set[str] = {
"temperature",
"top_p",
"top_k",
"max_tokens",
"min_tokens",
"seed",
"ignore_eos",
"stop",
"stop_token_ids",
"frequency_penalty",
"presence_penalty",
}
Expand Down