[BugFix] Fixed the issue where ignore_eos was not working.#1286
Merged
Gaohan123 merged 3 commits intovllm-project:mainfrom Feb 10, 2026
Merged
[BugFix] Fixed the issue where ignore_eos was not working.#1286Gaohan123 merged 3 commits intovllm-project:mainfrom
Gaohan123 merged 3 commits intovllm-project:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes OpenAI-compatible chat serving sampling-parameter override behavior so request-provided fields (notably ignore_eos) are applied when building SamplingParams for the comprehension stage (addresses #1242).
Changes:
- Expand the allowlist of request fields (
_OPENAI_SAMPLING_FIELDS) that can override YAML/default sampling params. - Ensure
ignore_eos(and additional sampling-related fields) are included in the override set.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
86d77b3 to
72ce3eb
Compare
Contributor
Author
|
@tzhouam PTAL |
Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com>
49f6354 to
b8ccba0
Compare
Contributor
Author
|
Further optimizations: vllm-omni needs to reuse the sampling parameter construction method of vllm. |
1 task
YanickSchraner
pushed a commit
to YanickSchraner/vllm-omni
that referenced
this pull request
Feb 20, 2026
…ect#1286) Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
Fix #1242
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)