Skip to content

Conversation

@horheynm
Copy link

SUMMARY:
Load Compressed Tensors Models with run_compressed=False

TEST PLAN:
Made tests to check that run_compressed=False (new pathway) do not have any Compressed Linear
Made tests to check that run_compressed=True (AutoModelForCausalLM pathway) has Compressed Linear.

"create_fake_dataloader",
"POSSIBLE_TOKENIZER_FILES",
"download_repo_from_huggingface_hub",
"detect_last_checkpoint",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabetical order

@github-actions
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

kylesayrs
kylesayrs previously approved these changes Nov 18, 2024
Copy link
Collaborator

@kylesayrs kylesayrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

config.quantization_config["run_compressed"] = False

return AutoModelForCausalLM.from_pretrained(
pretrained_model_name_or_path, config=config, **kwargs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wont we get the error you were seeing unless we set the status to Frozen in HFQuant? In which case, the test below will error out?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good point. The module set to frozen will be triggered from the HFQuantizer side

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this will error until then, we should wait until your change lands in HF and keep this in draft form.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes wait until its merged

Copy link
Collaborator

@dsikka dsikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you set this to draft since blocked on hf

@horheynm horheynm marked this pull request as draft November 22, 2024 17:32
@horheynm
Copy link
Author

@dsikka
sure thing

@horheynm
Copy link
Author

Dont need this no more, closing this pr

@horheynm horheynm closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants