Skip to content

Conversation

@dsikka
Copy link
Collaborator

@dsikka dsikka commented Nov 17, 2024

SUMMARY:

  • Make the test case useful
  • Previously testing identical model loads as run_compressed can't be turned off through the HFQuantizer pathway. Use ModelCompressor in its place until this is supported
  • Update prompt to be sensical

@dsikka dsikka changed the title Actually make the test useful Actually make the run_compressed test useful Nov 17, 2024
@github-actions
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

kylesayrs
kylesayrs previously approved these changes Nov 17, 2024
@dsikka dsikka added the ready When a PR is ready for review label Nov 17, 2024
@horheynm
Copy link

Nice Ill fix it up once the decompress pathway is solid on HFQuantizer

@horheynm
Copy link

horheynm commented Nov 19, 2024

Note that
we need #923
to load the model using run_compressed=False
and
HF side huggingface/transformers#34719
for setting status to frozen

to address the TODOs on the PR

horheynm
horheynm previously approved these changes Nov 19, 2024
@dsikka dsikka dismissed stale reviews from horheynm and kylesayrs via b7bd5cd November 20, 2024 14:56
@dsikka dsikka merged commit b61d4e5 into main Nov 21, 2024
5 of 7 checks passed
@dsikka dsikka deleted the fix_test branch November 21, 2024 02:38
kylesayrs added a commit that referenced this pull request Nov 21, 2024
Co-authored-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready When a PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants