Skip to content

feat(plugin-legacy): make terser optional if renderLegacyChunk false #9453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bluwy wants to merge 2 commits into from
Closed

feat(plugin-legacy): make terser optional if renderLegacyChunk false #9453

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f50693
feat(plugin-legacy): make terser optional if renderLegacyChunk false
bluwy Jul 30, 2022
22f5658
docs: update text
bluwy Aug 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/plugin-legacy/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export default {
}
```

Terser must be installed because plugin-legacy uses Terser for minification.
If `renderLegacyChunks` is not `false`, Terser must be installed because plugin-legacy uses Terser to minify legacy chunks.

```sh
npm add -D terser
Expand Down
5 changes: 5 additions & 0 deletions packages/plugin-legacy/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@
"terser": "^5.4.0",
"vite": "^3.0.0"
},
"peerDependenciesMeta": {
"terser": {
"optional": true
}
},
"devDependencies": {
"@babel/core": "^7.18.9",
"vite": "workspace:*"
Expand Down
4 changes: 3 additions & 1 deletion packages/plugin-legacy/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,9 @@ async function buildPolyfillChunk(
excludeSystemJS?: boolean
) {
let { minify, assetsDir } = buildOptions
minify = minify ? 'terser' : false
if (format === 'iife') {
minify = minify ? 'terser' : false
}
Comment on lines +651 to +653
Copy link
Member Author

@bluwy bluwy Jul 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This function is only called in two places. One for building the modern polyfilll chunk, two for legacy polyfill chunk. They pass es and iife respectively. So this changes that modern polyfills uses esbuild instead, which should be fine.

const res = await build({
// so that everything is resolved from here
root: path.dirname(fileURLToPath(import.meta.url)),
Expand Down