Skip to content

fix: scanner and optimizer should skip wasm#9257

Merged
patak-cat merged 1 commit intovitejs:mainfrom
sapphi-red:fix/optimizer-skip-wasm
Jul 20, 2022
Merged

fix: scanner and optimizer should skip wasm#9257
patak-cat merged 1 commit intovitejs:mainfrom
sapphi-red:fix/optimizer-skip-wasm

Conversation

@sapphi-red
Copy link
Member

Description

#8219 removed wasm from KNOWN_ASSET_TYPES to prevent import wasmUrl from './foo.wasm'.
But that caused scanner/optimizer to include wasm files.
This fixes that.

refs #9256

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) feat: wasm labels Jul 20, 2022
@patak-cat patak-cat merged commit c616077 into vitejs:main Jul 20, 2022
@sapphi-red sapphi-red deleted the fix/optimizer-skip-wasm branch July 20, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: wasm p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants