feat(wasm): new wasm plugin (.wasm?init)#8219
Merged
patak-cat merged 6 commits intovitejs:mainfrom May 20, 2022
Merged
Conversation
BREAKING CHANGE: `.wasm` no longer returns a Promise of the exports object of the wasm instance
bluwy
reviewed
May 19, 2022
bluwy
approved these changes
May 20, 2022
patak-cat
approved these changes
May 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements #7763.
Changes in this PR:
import foo from 'foo.wasm'no longer returns a value. Now it throws an error that shows "ESM integration for Wasm" is not supported.import foo from 'foo.wasm?init'behaves simillar to the previousimport foo from 'foo.wasm'. The difference is the previous one returnsWebAssembly.Exportsbut this returnsWebAssembly.Instance.close #3847
close #5615
refs #4551 (not close as this PR does not implement "ESM integration for Wasm")
superseds close #7181
Additional context
See #7763 for more details about the reasons.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).