docs: improve migration from v2 guide#8417
Merged
patak-cat merged 4 commits intovitejs:mainfrom May 31, 2022
Merged
Conversation
Shinigami92
approved these changes
May 31, 2022
patak-cat
approved these changes
May 31, 2022
Member
|
Thanks for the PR @sapphi-red 💚 About the ones you list in the description, I think it would be useful to have them in the migration guide in a new Advanced section. Maybe we could directly list the PR as you did here with a line each instead of a detailed explanation. And users can check the complete rationale and context in the PRs. What do you think? |
Member
Author
|
I think it would be useful. I'll create another PR for that! 👍 |
9 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I checked the commit log from 2.9.8 and added descriptions for breaking changes which was missing.
There are potentially breaking changes which I didn't include.
generatedCode: 'es2015'for rollup build #5018/// <reference lib="dom" />is removed fromvite/client.d.ts. This only affects users who does not have either{"lib": ["dom"]}nor{"lib": ["webworker"]}intsconfig.json.unbuildto bundle plugins #8139exportsfield now exists. For example, it breaks if someone is importingvite/dist/node/cli.jsdirectly which rarely happens.server.forceoption was removed in favor offorceoption.And some which only affects plugin/tool creators which I didn't include.
printHttpServerUrlsis removedserver.app,server.transformWithEsbuildare removedimport.meta.hot.acceptDepsis removedssrLoadModule'sfixStacktraceoption's default is nowfalseformatPostcssSourceMapis now asyncresolvePackageEntry,resolvePackageDataare no longer available from CJS build (dynamic import is needed to use in CJS)Also I didn't include breaking changes of plugins.
options.parserPluginsis removedentryFileNamesfor polyfill chunks #8247vite/legacy-polyfillsin manifest is nowvite/legacy-polyfills-legacy.polyfills-modern.hash.jsis nowpolyfills.hash.js.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).