Skip to content

chore: deprecate rollupOptions.output.output to avoid subtle errors #5930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patak-cat merged 2 commits into from
Dec 2, 2021
Merged

chore: deprecate rollupOptions.output.output to avoid subtle errors #5930

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e93d6b
chore: deprecate `rollupOptions.output.output` to avoid subtle errors
haoqunjiang Dec 2, 2021
c3743cb
chore: format with prettier
haoqunjiang Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/vite/src/node/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,15 @@ async function doBuild(

try {
const buildOutputOptions = (output: OutputOptions = {}): OutputOptions => {
// @ts-ignore
if (output.output) {
config.logger.warn(
`You've set "rollupOptions.output.output" in your config. ` +
`This is deprecated and will override all Vite.js default output options. ` +
`Please use "rollupOptions.output" instead.`
)
}

return {
dir: outDir,
format: ssr ? 'cjs' : 'es',
Expand Down