Skip to content

chore: deprecate rollupOptions.output.output to avoid subtle errors#5930

Merged
patak-cat merged 2 commits intovitejs:mainfrom
haoqunjiang:warn-output-dot-output
Dec 2, 2021
Merged

chore: deprecate rollupOptions.output.output to avoid subtle errors#5930
patak-cat merged 2 commits intovitejs:mainfrom
haoqunjiang:warn-output-dot-output

Conversation

@haoqunjiang
Copy link
Member

Description

As explained in #5812 (comment)

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

bluwy
bluwy previously approved these changes Dec 2, 2021
@Shinigami92
Copy link
Member

Prettier complains something about wrong formatting, pls run prettier

@Shinigami92 Shinigami92 added the p1-chore Doesn't change code behavior (priority) label Dec 2, 2021
@patak-cat patak-cat merged commit e3a1aa5 into vitejs:main Dec 2, 2021
sapphi-red added a commit to sapphi-red/vite that referenced this pull request Jun 1, 2022
@sapphi-red sapphi-red mentioned this pull request Jun 1, 2022
9 tasks
patak-cat pushed a commit that referenced this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1-chore Doesn't change code behavior (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants