feat: add vite-plugin-cloudflare

[dario-piotrowicz]

No description provided.

[dominikg]

i tried executing this locally and it failed because pnpm playwright install-deps tried to sudo something. Is that required?

looks to be coming from here https://github.com/cloudflare/workers-sdk/blob/59eda4af54f8eada5324bbd3014c41c934e566ac/packages/vite-plugin-cloudflare/playground/package.json#L9

[dario-piotrowicz]

i tried executing this locally and it failed because pnpm playwright install-deps tried to sudo something. Is that required?

mh... at the very least it is recommended by the playwright docs itself: https://playwright.dev/docs/browsers#install-system-dependencies 🤔

I don't think I've seen that error or sudo things 🤔 (I did test this workflow earlier today too)

what's the specific issue you're seeying?

[dominikg]

I'm running an arch based distribution locally and playwright isn't geared towards that. However many other tests here use pnpm playwright install chromium without deps or other browsers, so unless your tests need the other browsers and their dependencies i would prefer you change the script to only install chromium without dependencies as to avoid downloading unused things all over.

[dario-piotrowicz]

I'm running an arch based distribution locally and playwright isn't geared towards that. However many other tests here use pnpm playwright install chromium without deps or other browsers, so unless your tests need the other browsers and their dependencies i would prefer you change the script to only install chromium without dependencies as to avoid downloading unused things all over.

Ok, that's a good point, I'll look into that, thanks 🙂

[dario-piotrowicz]

@dominikg it should be fixed now 🙂

[dominikg]

great, ran the test locally and it passed 👍

[dario-piotrowicz]

I just now realized you merged the PR, thanks a bunch @dominikg 😄

[dominikg]

np, unfortunately sth failed from corepack with pnpm, will investigate later