-
Notifications
You must be signed in to change notification settings - Fork 1k
[vite-plugin-cloudflare] simplify playground playwright install #8141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vite-plugin-cloudflare] simplify playground playwright install #8141
Conversation
|
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-wrangler-8141You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8141/npm-package-wrangler-8141Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-wrangler-8141 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-cloudflare-workers-bindings-extension-8141 -O ./cloudflare-workers-bindings-extension.0.0.0-v268de6e8b.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v268de6e8b.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-create-cloudflare-8141 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-cloudflare-kv-asset-handler-8141miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-miniflare-8141@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-cloudflare-pages-shared-8141@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-cloudflare-unenv-preset-8141@cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-cloudflare-vite-plugin-8141@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-cloudflare-vitest-pool-workers-8141@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-cloudflare-workers-editor-shared-8141@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-cloudflare-workers-shared-8141@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-cloudflare-workflows-shared-8141Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
ca1d091 to
4d35d1b
Compare
petebacondarwin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should speed things up a bit too, eh?
This PR simplified the vite-plugin-cloudflare playground playwright installation by only installing the chromium browser and nothing else.
This should unblock: vitejs/vite-ecosystem-ci#361
Details
playwright install-depsdoesn't work great everywhere, for example it doesn't work on arch linux, the playwright docs are a bit vague on what it installs but it sounds like it might not be generally necessary (as you can also see from the successful CI runs in this PR).Besides that we only use the chromium browser so only that needs to actually be installed.