Skip to content

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Feb 14, 2025

This PR simplified the vite-plugin-cloudflare playground playwright installation by only installing the chromium browser and nothing else.

This should unblock: vitejs/vite-ecosystem-ci#361

Details

playwright install-deps doesn't work great everywhere, for example it doesn't work on arch linux, the playwright docs are a bit vague on what it installs but it sounds like it might not be generally necessary (as you can also see from the successful CI runs in this PR).

Besides that we only use the chromium browser so only that needs to actually be installed.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: infra change
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: unrelated to wrangler
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: infra change

@changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2025

⚠️ No Changeset found

Latest commit: 4d35d1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-wrangler-8141

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8141/npm-package-wrangler-8141

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-wrangler-8141 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-cloudflare-workers-bindings-extension-8141 -O ./cloudflare-workers-bindings-extension.0.0.0-v268de6e8b.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v268de6e8b.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-create-cloudflare-8141 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-cloudflare-kv-asset-handler-8141

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-miniflare-8141

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-cloudflare-pages-shared-8141

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-cloudflare-unenv-preset-8141

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-cloudflare-vite-plugin-8141

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-cloudflare-vitest-pool-workers-8141

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-cloudflare-workers-editor-shared-8141

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-cloudflare-workers-shared-8141

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13327746637/npm-package-cloudflare-workflows-shared-8141

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250204.1
workerd 1.20250204.0 1.20250204.0
workerd --version 1.20250204.0 2025-02-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@dario-piotrowicz dario-piotrowicz force-pushed the dario/vite-plugin/simplify-playground-playwright-deps branch from ca1d091 to 4d35d1b Compare February 14, 2025 10:55
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review February 14, 2025 11:03
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner February 14, 2025 11:03
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should speed things up a bit too, eh?

@petebacondarwin petebacondarwin merged commit a45c58b into main Feb 14, 2025
25 of 26 checks passed
@petebacondarwin petebacondarwin deleted the dario/vite-plugin/simplify-playground-playwright-deps branch February 14, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants