Add error handling in fetchEmbedding before accessing result hits#35728
Open
Add error handling in fetchEmbedding before accessing result hits#35728
Conversation
Co-authored-by: andreer <264780+andreer@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Address feedback on finding related docs in single query
Add error handling in fetchEmbedding before accessing result hits
Jan 29, 2026
andreer
approved these changes
Jan 30, 2026
bjorncs
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fetchEmbeddingmethod inRelatedDocumentsByNearestNeighborSearcherwas accessingresult.hits()without checking if the search operation failed, potentially causing issues when backend communication errors occur.Changes
execution.search(fetchQuery)to detect backend failuresnullwhenresult.hits().getError() != null, triggering appropriate error handling in the callerThis prevents proceeding with operations on a failed result and ensures graceful error propagation.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.