avoid sending modules in parent for dynamic imports #4056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
Contributor
|
Contributor
Benchmark for 1e5793e
Click to view full benchmark
|
sokra
force-pushed
the
sokra/dynamic-import-perf
branch
from
feb57ba to
1aecdea
Compare
Contributor
Benchmark for 9fbd8f5
Click to view full benchmark
|
sokra
force-pushed
the
sokra/dynamic-import-perf
branch
from
b550fa4 to
dd7f0ba
Compare
Contributor
Benchmark for 09b9ce9
Click to view full benchmark
|
alexkirsz
reviewed
Mar 8, 2023
sokra
force-pushed
the
sokra/dynamic-import-perf
branch
from
dd7f0ba to
4021fc4
Compare
alexkirsz
reviewed
Mar 10, 2023
alexkirsz
approved these changes
Mar 10, 2023
sokra
added
the
pr: automerge
Contributor
Benchmark for 3ac106d
Click to view full benchmark
|
use entry chunk for chunk list path instead of only module to include all info chunk path no longer depends on chunk group content for evaluated chunks
alexkirsz
suggested changes
Mar 10, 2023
Contributor
Benchmark for cafec2e
Click to view full benchmark
|
alexkirsz
approved these changes
Mar 10, 2023
Contributor
Benchmark for 5667ba3
Click to view full benchmark
|
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
…#4056) ### Description Keeps track of available modules when importing new chunk groups. Omits assets that are already available in the parent chunk group(s) when determining assets to be included in chunks. ### Testing Instructions Dynamic imports should not include modules that are already in the parent chunks <!-- When the below is checked (default) our PR bot will automatically assign labels to your PR based on the content to help the team organize and review it faster. --> - [x] Auto label fixes WEB-599
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
…#4056) ### Description Keeps track of available modules when importing new chunk groups. Omits assets that are already available in the parent chunk group(s) when determining assets to be included in chunks. ### Testing Instructions Dynamic imports should not include modules that are already in the parent chunks <!-- When the below is checked (default) our PR bot will automatically assign labels to your PR based on the content to help the team organize and review it faster. --> - [x] Auto label fixes WEB-599
Merged
kodiakhq bot
pushed a commit
that referenced
this pull request
Mar 14, 2023
### Description The fix introduced in #3542 was a workaround for CSS in dynamic imports being included multiple times in a page, potentially overriding precedence of earlier chunks, but introduced its own precedence issue (the semantics of `@layer` are not fully compatible with our use case). This is no longer necessary since #4056 made it so dynamic imports no longer include items from the parent chunk. ### Testing Instructions create-next-app with app support now looks visually identical with and without --turbo. Snapshots.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…#4056) ### Description Keeps track of available modules when importing new chunk groups. Omits assets that are already available in the parent chunk group(s) when determining assets to be included in chunks. ### Testing Instructions Dynamic imports should not include modules that are already in the parent chunks <!-- When the below is checked (default) our PR bot will automatically assign labels to your PR based on the content to help the team organize and review it faster. --> - [x] Auto label fixes WEB-599
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description The fix introduced in vercel/turborepo#3542 was a workaround for CSS in dynamic imports being included multiple times in a page, potentially overriding precedence of earlier chunks, but introduced its own precedence issue (the semantics of `@layer` are not fully compatible with our use case). This is no longer necessary since vercel/turborepo#4056 made it so dynamic imports no longer include items from the parent chunk. ### Testing Instructions create-next-app with app support now looks visually identical with and without --turbo. Snapshots.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…#4056) ### Description Keeps track of available modules when importing new chunk groups. Omits assets that are already available in the parent chunk group(s) when determining assets to be included in chunks. ### Testing Instructions Dynamic imports should not include modules that are already in the parent chunks <!-- When the below is checked (default) our PR bot will automatically assign labels to your PR based on the content to help the team organize and review it faster. --> - [x] Auto label fixes WEB-599
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description The fix introduced in vercel/turborepo#3542 was a workaround for CSS in dynamic imports being included multiple times in a page, potentially overriding precedence of earlier chunks, but introduced its own precedence issue (the semantics of `@layer` are not fully compatible with our use case). This is no longer necessary since vercel/turborepo#4056 made it so dynamic imports no longer include items from the parent chunk. ### Testing Instructions create-next-app with app support now looks visually identical with and without --turbo. Snapshots.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…#4056) ### Description Keeps track of available modules when importing new chunk groups. Omits assets that are already available in the parent chunk group(s) when determining assets to be included in chunks. ### Testing Instructions Dynamic imports should not include modules that are already in the parent chunks <!-- When the below is checked (default) our PR bot will automatically assign labels to your PR based on the content to help the team organize and review it faster. --> - [x] Auto label fixes WEB-599
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description The fix introduced in vercel/turborepo#3542 was a workaround for CSS in dynamic imports being included multiple times in a page, potentially overriding precedence of earlier chunks, but introduced its own precedence issue (the semantics of `@layer` are not fully compatible with our use case). This is no longer necessary since vercel/turborepo#4056 made it so dynamic imports no longer include items from the parent chunk. ### Testing Instructions create-next-app with app support now looks visually identical with and without --turbo. Snapshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Keeps track of available modules when importing new chunk groups. Omits assets that are already available in the parent chunk group(s) when determining assets to be included in chunks.
Testing Instructions
Dynamic imports should not include modules that are already in the parent chunks
fixes WEB-599