Revert #3542 #4197
Merged
Revert #3542 #4197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
kwonoj
approved these changes
Mar 14, 2023
alexkirsz
added
the
pr: automerge
Contributor
|
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description The fix introduced in vercel/turborepo#3542 was a workaround for CSS in dynamic imports being included multiple times in a page, potentially overriding precedence of earlier chunks, but introduced its own precedence issue (the semantics of `@layer` are not fully compatible with our use case). This is no longer necessary since vercel/turborepo#4056 made it so dynamic imports no longer include items from the parent chunk. ### Testing Instructions create-next-app with app support now looks visually identical with and without --turbo. Snapshots.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description The fix introduced in vercel/turborepo#3542 was a workaround for CSS in dynamic imports being included multiple times in a page, potentially overriding precedence of earlier chunks, but introduced its own precedence issue (the semantics of `@layer` are not fully compatible with our use case). This is no longer necessary since vercel/turborepo#4056 made it so dynamic imports no longer include items from the parent chunk. ### Testing Instructions create-next-app with app support now looks visually identical with and without --turbo. Snapshots.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description The fix introduced in vercel/turborepo#3542 was a workaround for CSS in dynamic imports being included multiple times in a page, potentially overriding precedence of earlier chunks, but introduced its own precedence issue (the semantics of `@layer` are not fully compatible with our use case). This is no longer necessary since vercel/turborepo#4056 made it so dynamic imports no longer include items from the parent chunk. ### Testing Instructions create-next-app with app support now looks visually identical with and without --turbo. Snapshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The fix introduced in #3542 was a workaround for CSS in dynamic imports being included multiple times in a page, potentially overriding precedence of earlier chunks, but introduced its own precedence issue (the semantics of
@layerare not fully compatible with our use case). This is no longer necessary since #4056 made it so dynamic imports no longer include items from the parent chunk.Testing Instructions
create-next-app with app support now looks visually identical with and without --turbo.
Snapshots.