Skip to content

fix: don't inline system env vars #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mischnic merged 2 commits into from
Feb 16, 2026
Merged

fix: don't inline system env vars #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f20047
fix: don't inline env vars
mischnic Feb 9, 2026
9a9d104
changeset
mischnic Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/spicy-dingos-speak.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@vercel/otel": patch
---

fix: don't inline system env vars
8 changes: 2 additions & 6 deletions packages/otel/src/instrumentations/fetch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,12 +169,8 @@ export class FetchInstrumentation implements Instrumentation {
}

private shouldPropagate(url: URL, init?: InternalRequestInit): boolean {
const host =
process.env.VERCEL_URL || process.env.NEXT_PUBLIC_VERCEL_URL || null;
const branchHost =
process.env.VERCEL_BRANCH_URL ||
process.env.NEXT_PUBLIC_VERCEL_BRANCH_URL ||
null;
const host = process.env.VERCEL_URL || null;
const branchHost = process.env.VERCEL_BRANCH_URL || null;
const propagateContextUrls = this.config.propagateContextUrls ?? [];
const dontPropagateContextUrls = this.config.dontPropagateContextUrls ?? [];
if (init?.opentelemetry?.propagateContext) {
Expand Down
16 changes: 4 additions & 12 deletions packages/otel/src/sdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,20 +128,12 @@ export class Sdk {
// Vercel.
// https://vercel.com/docs/projects/environment-variables/system-environment-variables
// Vercel Env set as top level attribute for simplicity. One of 'production', 'preview' or 'development'.
env: process.env.VERCEL_ENV || process.env.NEXT_PUBLIC_VERCEL_ENV,
env: process.env.VERCEL_ENV,
"vercel.region": process.env.VERCEL_REGION,
"vercel.runtime": runtime,
"vercel.sha":
process.env.VERCEL_GIT_COMMIT_SHA ||
process.env.NEXT_PUBLIC_VERCEL_GIT_COMMIT_SHA,
"vercel.host":
process.env.VERCEL_URL ||
process.env.NEXT_PUBLIC_VERCEL_URL ||
undefined,
"vercel.branch_host":
process.env.VERCEL_BRANCH_URL ||
process.env.NEXT_PUBLIC_VERCEL_BRANCH_URL ||
undefined,
"vercel.sha": process.env.VERCEL_GIT_COMMIT_SHA,
"vercel.host": process.env.VERCEL_URL || undefined,
"vercel.branch_host": process.env.VERCEL_BRANCH_URL || undefined,
"vercel.deployment_id": process.env.VERCEL_DEPLOYMENT_ID || undefined,
[SemanticResourceAttributes.SERVICE_VERSION]:
process.env.VERCEL_DEPLOYMENT_ID,
Expand Down