Skip to content

fix: don't inline system env vars#190

Merged
mischnic merged 2 commits intomainfrom
mischnic/no-inlining
Feb 16, 2026
Merged

fix: don't inline system env vars#190
mischnic merged 2 commits intomainfrom
mischnic/no-inlining

Conversation

@mischnic
Copy link
Member

@mischnic mischnic commented Feb 9, 2026

My understanding is that all of this code runs only server-side
In that case, there is no benefit to trying to fallback to NEXT_PUBLIC_VERCEL_URL (the only case where it's necessary is for client-side code, where there is obviously no process.env at runtime.)

This means that the JS chunks in the serverless function are now deterministic as NEXT_PUBLIC_ always inlined the value into the JS chunk

@vercel
Copy link

vercel bot commented Feb 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
otel-site Ready Ready Preview, Comment, Open in v0 Feb 16, 2026 10:03am

@mischnic mischnic changed the title fix: don't inline env vars fix: don't inline system env vars Feb 9, 2026
@mischnic mischnic merged commit 41d4511 into main Feb 16, 2026
8 checks passed
@mischnic mischnic deleted the mischnic/no-inlining branch February 16, 2026 10:27
@github-actions github-actions bot mentioned this pull request Feb 16, 2026
kakadiadarpan pushed a commit that referenced this pull request Feb 16, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @vercel/[email protected]

### Patch Changes

- [#190](#190)
[`41d4511`](41d4511)
Thanks [@mischnic](https://github.com/mischnic)! - fix: don't inline
system env vars

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants