chore(ci): always run lint #48024
Closed
chore(ci): always run lint #48024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuding
approved these changes
Apr 6, 2023
huozhi
approved these changes
Apr 6, 2023
Member
Author
|
Closing in favor of #48023 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #47955, the docs were updated to include a word that is not allowed. However, lint was skipped and the PR merged.
Subsequent PRs that ran lint were failing.
So we had to add the word to the allow list in PR #48021.
To fix this type of problem, we should always run lint unconditionally.