Skip to content

Conversation

@sokra
Copy link
Member

@sokra sokra commented Apr 6, 2023

What

Docs changes need to be linted for language

@sokra sokra requested review from a team and leerob as code owners April 6, 2023 14:29
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use #48021 instead

@sokra
Copy link
Member Author

sokra commented Apr 6, 2023

Let's use #48021 instead

Ok changed it to fix the lint step on CI

@sokra sokra enabled auto-merge April 6, 2023 15:00
@ijjk
Copy link
Member

ijjk commented Apr 6, 2023

Failing test suites

Commit: 876815a

pnpm testheadless test/e2e/app-dir/navigation/navigation.test.ts

  • app dir - navigation > redirect > components > should redirect to external url
Expand output

● app dir - navigation › redirect › components › should redirect to external url

thrown: "Exceeded timeout of 240000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  157 |         })
  158 |
> 159 |         it('should redirect to external url', async () => {
      |         ^
  160 |           const browser = await next.browser('/redirect/external')
  161 |           expect(await browser.waitForElementByCss('h1').text()).toBe(
  162 |             'Example Domain'

  at e2e/app-dir/navigation/navigation.test.ts:159:9
  at e2e/app-dir/navigation/navigation.test.ts:130:7
  at fn (e2e/app-dir/navigation/navigation.test.ts:129:5)
  at lib/e2e-utils.ts:242:5

Read more about building and testing Next.js in contributing.md.

@sokra sokra disabled auto-merge April 6, 2023 15:16
@sokra sokra merged commit dec037a into canary Apr 6, 2023
@sokra sokra deleted the sokra/fix-lint branch April 6, 2023 15:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

created-by: Turbopack team PRs by the Turbopack team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants