Fix typos and replace 'codespell' with 'typos'#72
Conversation
.config/typos.toml
Outdated
| fle = "fle" | ||
| nd = "nd" | ||
| ot = "ot" | ||
| module_gil_acquring = "module_gil_acquring" |
There was a problem hiding this comment.
this is in an extern variable type, so I didnt want to rename it without discussion.
However, especially given valkey is still unstable, maybe this is a good time to do the rename.
Does valkey want to retain API or ABI compatibility?
There was a problem hiding this comment.
Note this isnt listed in the codespell wordlist.
|
|
||
| /* Make the thread killable at any time, so that kill threads functions | ||
| * can work reliably (default cancelability type is PTHREAD_CANCEL_DEFERRED). | ||
| * can work reliably (default cancellability type is PTHREAD_CANCEL_DEFERRED). |
There was a problem hiding this comment.
https://en.wiktionary.org/wiki/cancelability and the note at the bottom of https://www.merriam-webster.com/dictionary/cancel suggests this was an acceptable alternative , but given it only appears once, and it looks like it will get flagged by multiple spellcheckers, it seems wise to just switch to using the spelling commonly used.
|
Please consider dropping codespell. |
I am not familiar with codespell nor spellchecker in general. Are you saying that the existing spellchecker is sufficient? BTW, @jayvdb, all other changes LGTM. Thanks! |
|
I did a bit of digging and can confirm |
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
LGTM
How can I run typos locally? It's useful to be able to run it before pushing, instead of waiting for CI failure to find out.
See https://github.com/crate-ci/typos?tab=readme-ov-file#install |
Just download typos, it is a single binary. Nicely fits in |
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
Sounds good then.
I'm leaving this open for a little while to let others look before merging.
Signed-off-by: John Vandenberg <jayvdb@gmail.com>
|
Looks like we are in general agreement with the bulk of the changes. I am going to merge this PR now to reduce the PR backlog. We can always take incremental changes. |
These were flagged on the 7.2 build system, which is using the old spell check. I think we should consider re-adding it as it missed some typos. Relevant: #72 Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
These were flagged on the 7.2 build system, which is using the old spell check. I think we should consider re-adding it as it missed some typos. Relevant: valkey-io#72 Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Uses https://github.com/taiki-e/install-action to install https://github.com/crate-ci/typos in CI This finds many more/different typos than https://github.com/codespell-project/codespell , while having very few false positives. Signed-off-by: John Vandenberg <jayvdb@gmail.com>
These were flagged on the 7.2 build system, which is using the old spell check. I think we should consider re-adding it as it missed some typos. Relevant: valkey-io#72 Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
5 participants
Uses https://github.com/taiki-e/install-action to install https://github.com/crate-ci/typos in CI
This finds many more/different typos than https://github.com/codespell-project/codespell , while having very few false positives.