Fix two typos that were flagged in the 7.2 build#248
Merged
madolson merged 1 commit intovalkey-io:unstablefrom Apr 7, 2024
Merged
Fix two typos that were flagged in the 7.2 build#248madolson merged 1 commit intovalkey-io:unstablefrom
madolson merged 1 commit intovalkey-io:unstablefrom
Conversation
Signed-off-by: Madelyn Olson <[email protected]>
enjoy-binbin
approved these changes
Apr 7, 2024
Member
enjoy-binbin
left a comment
enjoy-binbin
left a comment
There was a problem hiding this comment.
I think we should consider re-adding it as it missed some typos.
you means we try to keep both codespell' and 'typos'?
Member
Author
Or update typos so that it's able to catch these types of issues. I haven't looked into it enough. |
madolson
added a commit
to madolson/valkey
that referenced
this pull request
Apr 7, 2024
These were flagged on the 7.2 build system, which is using the old spell check. I think we should consider re-adding it as it missed some typos. Relevant: valkey-io#72 Signed-off-by: Madelyn Olson <[email protected]>
PatrickJS
pushed a commit
to PatrickJS/placeholderkv
that referenced
this pull request
Apr 24, 2024
These were flagged on the 7.2 build system, which is using the old spell check. I think we should consider re-adding it as it missed some typos. Relevant: valkey-io#72 Signed-off-by: Madelyn Olson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were flagged on the 7.2 build system, which is using the old spell check. I think we should consider re-adding it as it missed some typos.
Relevant: #72