Cleanup tcl tmp directory leaking resources #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madolson
approved these changes
Mar 26, 2024
PatrickJS
pushed a commit
to PatrickJS/placeholderkv
that referenced
this pull request
Apr 24, 2024
Few of the servers log are stored as `server1/2/3.log` . Various type of acl files are created and weren't getting cleaned up prior to this change.
enjoy-binbin
added a commit
to enjoy-binbin/valkey
that referenced
this pull request
Mar 28, 2025
The tmpdir is `[tmpdir "acl"]` and did not meet valkey-io#34 requirements. Signed-off-by: Binbin <[email protected]>
zuiderkwast
pushed a commit
to zuiderkwast/placeholderkv
that referenced
this pull request
Sep 30, 2025
Few of the servers log are stored as `server1/2/3.log` . Various type of acl files are created and weren't getting cleaned up prior to this change.
zuiderkwast
pushed a commit
that referenced
this pull request
Oct 1, 2025
Few of the servers log are stored as `server1/2/3.log` . Various type of acl files are created and weren't getting cleaned up prior to this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few of the servers log are stored as
server1/2/3.log. Various type of acl files are created and weren't getting cleaned up prior to this change.