Fix TCL tmp dir leak in the ACL load test #1895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tmpdir is `[tmpdir "acl"]` and did not meet valkey-io#34 requirements. Signed-off-by: Binbin <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1895 +/- ##
============================================
- Coverage 71.04% 71.01% -0.04%
============================================
Files 123 123
Lines 65673 65673
============================================
- Hits 46659 46638 -21
- Misses 19014 19035 +21 🚀 New features to boost your workflow:
|
hpatro
approved these changes
Mar 28, 2025
ranshid
pushed a commit
to ranshid/valkey
that referenced
this pull request
Mar 31, 2025
Signed-off-by: Binbin <[email protected]>
ranshid
pushed a commit
that referenced
this pull request
Mar 31, 2025
Signed-off-by: Binbin <[email protected]>
zarkash-aws
pushed a commit
to zarkash-aws/valkey
that referenced
this pull request
Apr 6, 2025
Signed-off-by: Binbin <[email protected]> Signed-off-by: Shai Zarka <[email protected]>
murphyjacob4
pushed a commit
to enjoy-binbin/valkey
that referenced
this pull request
Apr 13, 2025
Signed-off-by: Binbin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tmpdir is
[tmpdir "acl"]and did not meet #34 requirements.