-
Notifications
You must be signed in to change notification settings - Fork 949
Weekly Test Runs on Released Branches #2702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
Weekly Test Runs on Released Branches #2702
Conversation
0de885f to
4622032
Compare
roshkhatri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should prefer to use github workflow actions more than relying on APIs
hpatro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you run it in your fork and share the run link here? Would like to visualize it.
@roshkhatri mentioned the daily runs on active PR against release branch. Do they conflict with each other or they just run in queued manner.
8691d22 to
03c3d04
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #2702 +/- ##
============================================
+ Coverage 72.41% 72.43% +0.02%
============================================
Files 128 128
Lines 70261 70261
============================================
+ Hits 50879 50896 +17
+ Misses 19382 19365 -17 🚀 New features to boost your workflow:
|
Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
d59d1a4 to
769325d
Compare
Signed-off-by: Sarthak Aggarwal <[email protected]>
769325d to
050f73c
Compare
|
@hpatro @roshkhatri I added a link in the PR description to visualize the test.
They run in a queued manner. |
roshkhatri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Can you also add screen shots of the workflow runs as an example in the top comment?? |
|
@roshkhatri there is a link in the top comment to display how it looks like. |
Nikhil-Manglore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@madolson please help review whenever you get a chance! Thank you! |
Resolves: #2228
Visualization: https://github.com/sarthakaggarwal97/valkey/actions/runs/19113712295
Currently, there are no tests running on the already released branches. We often do backport for bug fixes and CVEs in these older versions, and end up with multiple CI tests failures on these branches.
The PR adds support for running weekly tests on already released versions
>= 7.2. The workflow will execute the "daily" test workflow for each of these branches onSunday 06:00 UTC.The idea is to continuously monitor our released versions through weekly test runs (during the time when is lesser activity on github runners).