Skip to content

Conversation

@sarthakaggarwal97
Copy link
Contributor

@sarthakaggarwal97 sarthakaggarwal97 commented Oct 7, 2025

Resolves: #2228

Visualization: https://github.com/sarthakaggarwal97/valkey/actions/runs/19113712295

Currently, there are no tests running on the already released branches. We often do backport for bug fixes and CVEs in these older versions, and end up with multiple CI tests failures on these branches.

The PR adds support for running weekly tests on already released versions >= 7.2. The workflow will execute the "daily" test workflow for each of these branches on Sunday 06:00 UTC.

The idea is to continuously monitor our released versions through weekly test runs (during the time when is lesser activity on github runners).

Copy link
Member

@roshkhatri roshkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should prefer to use github workflow actions more than relying on APIs

Copy link
Collaborator

@hpatro hpatro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run it in your fork and share the run link here? Would like to visualize it.

@roshkhatri mentioned the daily runs on active PR against release branch. Do they conflict with each other or they just run in queued manner.

@sarthakaggarwal97 sarthakaggarwal97 force-pushed the weekly-release-daily-tests branch 2 times, most recently from 8691d22 to 03c3d04 Compare October 10, 2025 01:01
@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.43%. Comparing base (32844b8) to head (050f73c).

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #2702      +/-   ##
============================================
+ Coverage     72.41%   72.43%   +0.02%     
============================================
  Files           128      128              
  Lines         70261    70261              
============================================
+ Hits          50879    50896      +17     
+ Misses        19382    19365      -17     

see 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
@sarthakaggarwal97 sarthakaggarwal97 force-pushed the weekly-release-daily-tests branch 7 times, most recently from d59d1a4 to 769325d Compare November 5, 2025 18:24
@sarthakaggarwal97 sarthakaggarwal97 force-pushed the weekly-release-daily-tests branch from 769325d to 050f73c Compare November 5, 2025 18:37
@sarthakaggarwal97 sarthakaggarwal97 marked this pull request as ready for review November 5, 2025 20:01
@sarthakaggarwal97
Copy link
Contributor Author

sarthakaggarwal97 commented Nov 5, 2025

@hpatro @roshkhatri I added a link in the PR description to visualize the test.
Currently, it only ran for 8.0 and 8.1 in my fork, because I only had those branches in my fork. In valkey repo, it should be running on all the Valkey released branches. Please take a look.

Do they conflict with each other or they just run in queued manner.

They run in a queued manner.

@hpatro hpatro requested a review from roshkhatri November 6, 2025 23:11
Copy link
Member

@roshkhatri roshkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roshkhatri
Copy link
Member

Can you also add screen shots of the workflow runs as an example in the top comment??

@hpatro hpatro requested a review from madolson November 11, 2025 19:10
@sarthakaggarwal97
Copy link
Contributor Author

sarthakaggarwal97 commented Nov 11, 2025

@roshkhatri there is a link in the top comment to display how it looks like.
PS: It only ran on 8.0 and 8.1 branches because locally I had fetched only those two branches.

Copy link
Member

@Nikhil-Manglore Nikhil-Manglore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarthakaggarwal97
Copy link
Contributor Author

@madolson please help review whenever you get a chance! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[NEW] Run the whole test suite weekly on release branches

4 participants