addressing comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

Author: sarthakaggarwal97

.github/workflows/daily.yml

@@ -1,5 +1,4 @@
 name: Daily
-
 on:
   pull_request:
     branches:
@@ -32,14 +31,43 @@ on:
       use_git_ref:
         description: "git branch or sha to use"
         default: "unstable"
-
+  workflow_call:
+    inputs:
+      skipjobs:
+        description: "jobs to skip (delete the ones you wanna keep, do not leave empty)"
+        required: false
+        type: string
+        default: "valgrind,sanitizer,tls,freebsd,macos,alpine,32bit,iothreads,ubuntu,rpm-distros,malloc,specific,fortify,reply-schema,arm,lttng"
+      skiptests:
+        description: "tests to skip (delete the ones you wanna keep, do not leave empty)"
+        required: false
+        type: string
+        default: "valkey,modules,sentinel,cluster,unittest,large-memory"
+      test_args:
+        description: "extra test arguments"
+        required: false
+        type: string
+        default: ""
+      cluster_test_args:
+        description: "extra cluster / sentinel test arguments"
+        required: false
+        type: string
+        default: ""
+      use_repo:
+        description: "repo owner and name"
+        required: false
+        type: string
+        default: "valkey-io/valkey"
+      use_git_ref:
+        description: "git branch or sha to use"
+        required: false
+        type: string
+        default: "unstable"
 concurrency:
-  group: daily-${{ github.head_ref || github.ref }}
+  group: daily-${{ github.head_ref || github.event.inputs.use_git_ref || github.ref }}
   cancel-in-progress: true
-
 permissions:
   contents: read
-
 jobs:
   test-ubuntu-jemalloc:
     runs-on: ubuntu-latest
@@ -108,7 +136,6 @@ jobs:
         run: |
           sudo apt-get install tcl8.6 tclx
           ./runtest --verbose --tags compatible-redis --dump-logs --other-server-path tests/tmp/redis-7.0.15/src/redis-server
-
   test-ubuntu-arm:
     runs-on: ubuntu-24.04-arm
     if: |
@@ -150,7 +177,6 @@ jobs:
       - name: unittest
         if: true && !contains(github.event.inputs.skiptests, 'unittest')
         run: ./src/valkey-unit-tests --accurate
-
   test-ubuntu-jemalloc-fortify:
     runs-on: ubuntu-latest
     if: |
@@ -196,7 +222,6 @@ jobs:
       - name: unittest
         if: true && !contains(github.event.inputs.skiptests, 'unittest')
         run: ./src/valkey-unit-tests --accurate
-
   test-ubuntu-libc-malloc:
     runs-on: ubuntu-latest
     if: |
@@ -235,7 +260,6 @@ jobs:
       - name: cluster tests
         if: true && !contains(github.event.inputs.skiptests, 'cluster')
         run: ./runtest-cluster ${{github.event.inputs.cluster_test_args}}
-
   test-ubuntu-no-malloc-usable-size:
     runs-on: ubuntu-latest
     if: |
@@ -274,7 +298,6 @@ jobs:
       - name: cluster tests
         if: true && !contains(github.event.inputs.skiptests, 'cluster')
         run: ./runtest-cluster ${{github.event.inputs.cluster_test_args}}
-
   test-ubuntu-32bit:
     runs-on: ubuntu-latest
     if: |
@@ -320,7 +343,6 @@ jobs:
       - name: unittest
         if: true && !contains(github.event.inputs.skiptests, 'unittest')
         run: ./src/valkey-unit-tests --accurate
-
   test-ubuntu-tls:
     runs-on: ubuntu-latest
     if: |
@@ -366,7 +388,6 @@ jobs:
         if: true && !contains(github.event.inputs.skiptests, 'cluster')
         run: |
           ./runtest-cluster --tls ${{github.event.inputs.cluster_test_args}}
-
   test-ubuntu-tls-no-tls:
     runs-on: ubuntu-latest
     if: |
@@ -412,7 +433,6 @@ jobs:
         if: true && !contains(github.event.inputs.skiptests, 'cluster')
         run: |
           ./runtest-cluster ${{github.event.inputs.cluster_test_args}}
-
   test-ubuntu-io-threads:
     runs-on: ubuntu-latest
     if: |
@@ -446,7 +466,6 @@ jobs:
       - name: cluster tests
         if: true && !contains(github.event.inputs.skiptests, 'cluster')
         run: ./runtest-cluster --io-threads ${{github.event.inputs.cluster_test_args}}
-
   test-ubuntu-tls-io-threads:
     runs-on: ubuntu-latest
     if: |
@@ -484,7 +503,6 @@ jobs:
         if: true && !contains(github.event.inputs.skiptests, 'cluster')
         run: |
           ./runtest-cluster --io-threads --tls ${{github.event.inputs.cluster_test_args}}
-
   test-ubuntu-reclaim-cache:
     runs-on: ubuntu-latest
     if: |
@@ -560,7 +578,6 @@ jobs:
           CACHE=$(grep -w file /sys/fs/cgroup/memory.stat | awk '{print $2}')
           echo "$CACHE"
           if [ "$(( $CACHE-$CACHE0 ))" -gt "8000000" ]; then exit 1; fi
-
   test-valgrind-test:
     runs-on: ubuntu-latest
     if: |
@@ -592,7 +609,6 @@ jobs:
       - name: test
         if: true && !contains(github.event.inputs.skiptests, 'valkey')
         run: ./runtest --valgrind --no-latency --verbose --clients 1 --timeout 2400 --dump-logs ${{github.event.inputs.test_args}}
-
   test-valgrind-misc:
     runs-on: ubuntu-latest
     if: |
@@ -629,7 +645,6 @@ jobs:
         run: |
           valgrind --track-origins=yes --suppressions=./src/valgrind.sup --show-reachable=no --show-possibly-lost=no --leak-check=full --log-file=err.txt ./src/valkey-unit-tests --valgrind
           if grep -q 0x err.txt; then cat err.txt; exit 1; fi
-
   test-valgrind-no-malloc-usable-size-test:
     runs-on: ubuntu-latest
     if: |
@@ -661,7 +676,6 @@ jobs:
       - name: test
         if: true && !contains(github.event.inputs.skiptests, 'valkey')
         run: ./runtest --valgrind --no-latency --verbose --clients 1 --timeout 2400 --dump-logs ${{github.event.inputs.test_args}}
-
   test-valgrind-no-malloc-usable-size-misc:
     runs-on: ubuntu-latest
     if: |
@@ -698,7 +712,6 @@ jobs:
         run: |
           valgrind --track-origins=yes --suppressions=./src/valgrind.sup --show-reachable=no --show-possibly-lost=no --leak-check=full --log-file=err.txt ./src/valkey-unit-tests --valgrind
           if grep -q 0x err.txt; then cat err.txt; exit 1; fi
-
   test-sanitizer-address:
     runs-on: ubuntu-latest
     if: |
@@ -754,7 +767,6 @@ jobs:
       - name: large memory module api tests
         if: true && !contains(github.event.inputs.skiptests, 'modules') && !contains(github.event.inputs.skiptests, 'large-memory')
         run: CFLAGS='-Werror' ./runtest-moduleapi --verbose --dump-logs --large-memory --tags large-memory ${{github.event.inputs.test_args}}
-
   test-sanitizer-undefined:
     runs-on: ubuntu-latest
     if: |
@@ -810,7 +822,6 @@ jobs:
       - name: large memory module api tests
         if: true && !contains(github.event.inputs.skiptests, 'modules') && !contains(github.event.inputs.skiptests, 'large-memory')
         run: CFLAGS='-Werror' ./runtest-moduleapi --verbose --dump-logs --large-memory --tags large-memory ${{github.event.inputs.test_args}}
-
   test-sanitizer-force-defrag:
     runs-on: ubuntu-latest
     if: |
@@ -856,7 +867,6 @@ jobs:
       - name: unittest
         if: true && !contains(github.event.inputs.skiptests, 'unittest')
         run: ./src/valkey-unit-tests
-
   test-ubuntu-lttng:
     runs-on: ubuntu-latest
     if: |
@@ -897,7 +907,6 @@ jobs:
       - name: cluster tests
         if: true && !contains(github.event.inputs.skiptests, 'cluster')
         run: ./runtest-cluster ${{github.event.inputs.cluster_test_args}}
-
   test-rpm-distros-jemalloc:
     if: |
       (github.event_name == 'workflow_dispatch' ||
@@ -921,13 +930,10 @@ jobs:
             container: fedora:latest
           - name: test-fedorarawhide-jemalloc
             container: fedora:rawhide
-
     name: ${{ matrix.name }}
     runs-on: ubuntu-latest
-
     container: ${{ matrix.container }}
     timeout-minutes: 1440
-
     steps:
       - name: prep
         if: github.event_name == 'workflow_dispatch'
@@ -963,7 +969,6 @@ jobs:
       - name: cluster tests
         if: true && !contains(github.event.inputs.skiptests, 'cluster')
         run: ./runtest-cluster ${{github.event.inputs.cluster_test_args}}
-
   test-rpm-distros-tls-module:
     if: |
       (github.event_name == 'workflow_dispatch' ||
@@ -987,13 +992,10 @@ jobs:
             container: fedora:latest
           - name: test-fedorarawhide-tls-module
             container: fedora:rawhide
-
     name: ${{ matrix.name }}
     runs-on: ubuntu-latest
-
     container: ${{ matrix.container }}
     timeout-minutes: 1440
-
     steps:
       - name: prep
         if: github.event_name == 'workflow_dispatch'
@@ -1035,7 +1037,6 @@ jobs:
         if: true && !contains(github.event.inputs.skiptests, 'cluster')
         run: |
           ./runtest-cluster --tls-module ${{github.event.inputs.cluster_test_args}}
-
   test-rpm-distros-tls-module-no-tls:
     if: |
       (github.event_name == 'workflow_dispatch' ||
@@ -1059,13 +1060,10 @@ jobs:
             container: fedora:latest
           - name: test-fedorarawhide-tls-module-no-tls
             container: fedora:rawhide
-
     name: ${{ matrix.name }}
     runs-on: ubuntu-latest
-
     container: ${{ matrix.container }}
     timeout-minutes: 1440
-
     steps:
       - name: prep
         if: github.event_name == 'workflow_dispatch'
@@ -1107,7 +1105,6 @@ jobs:
         if: true && !contains(github.event.inputs.skiptests, 'cluster')
         run: |
           ./runtest-cluster ${{github.event.inputs.cluster_test_args}}
-
   test-macos-latest:
     runs-on: macos-latest
     if: |
@@ -1138,7 +1135,6 @@ jobs:
       - name: module api test
         if: true && !contains(github.event.inputs.skiptests, 'modules')
         run: CFLAGS='-Werror' ./runtest-moduleapi --verbose --clients 1 --no-latency --dump-logs ${{github.event.inputs.test_args}}
-
   test-macos-latest-sentinel:
     runs-on: macos-latest
     if: |
@@ -1166,7 +1162,6 @@ jobs:
       - name: sentinel tests
         if: true && !contains(github.event.inputs.skiptests, 'sentinel')
         run: ./runtest-sentinel ${{github.event.inputs.cluster_test_args}}
-
   test-macos-latest-cluster:
     runs-on: macos-latest
     if: |
@@ -1194,7 +1189,6 @@ jobs:
       - name: cluster tests
         if: true && !contains(github.event.inputs.skiptests, 'cluster')
         run: ./runtest-cluster ${{github.event.inputs.cluster_test_args}}
-
   build-old-macos-versions:
     strategy:
       fail-fast: false
@@ -1226,7 +1220,6 @@ jobs:
           ref: ${{ env.GITHUB_HEAD_REF }}
       - name: make
         run: make SERVER_CFLAGS='-Werror'
-
   test-freebsd:
     runs-on: macos-13
     if: |
@@ -1256,7 +1249,6 @@ jobs:
             sudo pkg install -y bash gmake lang/tcl86 lang/tclx
             gmake
             ./runtest --single unit/keyspace --single unit/auth --single unit/networking --single unit/protocol
-
   test-alpine-jemalloc:
     runs-on: ubuntu-latest
     if: |
@@ -1297,7 +1289,6 @@ jobs:
       - name: cluster tests
         if: true && !contains(github.event.inputs.skiptests, 'cluster')
         run: ./runtest-cluster ${{github.event.inputs.cluster_test_args}}
-
   test-alpine-libc-malloc:
     runs-on: ubuntu-latest
     if: |
@@ -1338,7 +1329,6 @@ jobs:
       - name: cluster tests
         if: true && !contains(github.event.inputs.skiptests, 'cluster')
         run: ./runtest-cluster ${{github.event.inputs.cluster_test_args}}
-
   reply-schemas-validator:
     runs-on: ubuntu-latest
     timeout-minutes: 1440
@@ -1383,7 +1373,6 @@ jobs:
           path: "./utils/req-res-validator/requirements.txt"
       - name: validator
         run: ./utils/req-res-log-validator.py --verbose --fail-missing-reply-schemas ${{ (!contains(github.event.inputs.skiptests, 'valkey') && !contains(github.event.inputs.skiptests, 'module') && !contains(github.event.inputs.sentinel, 'valkey') && !contains(github.event.inputs.skiptests, 'cluster')) && github.event.inputs.test_args == '' && github.event.inputs.cluster_test_args == '' && '--fail-commands-not-all-hit' || '' }}
-
   notify-about-job-results:
     runs-on: ubuntu-latest
     if: always() && github.event_name == 'schedule' && github.repository == 'valkey-io/valkey'