Skip to content

Conversation

@ranshid
Copy link
Member

@ranshid ranshid commented Aug 6, 2025

test_vest uses a mock_defrag function in order to simulate defrag flow.
In the scenario of no system malloc_size we need to use zmalloc_usable_size in order to prevent stepping over the "to-be-replaced" buffer

will partially fix: #2435

@ranshid ranshid force-pushed the fix-hfe-no-malloc-size-unit branch from cd89708 to a8ad694 Compare August 6, 2025 08:20
@ranshid ranshid force-pushed the fix-hfe-no-malloc-size-unit branch from a8ad694 to 12f1c98 Compare August 6, 2025 08:23
@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.52%. Comparing base (db11e41) to head (12f1c98).
⚠️ Report is 1 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #2436      +/-   ##
============================================
- Coverage     71.52%   71.52%   -0.01%     
============================================
  Files           125      125              
  Lines         69213    69213              
============================================
- Hits          49505    49503       -2     
- Misses        19708    19710       +2     

see 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ranshid ranshid merged commit ba7334c into valkey-io:unstable Aug 6, 2025
52 of 53 checks passed
allenss-amazon pushed a commit to allenss-amazon/valkey-core that referenced this pull request Aug 19, 2025
test_vest uses a mock_defrag function in order to simulate defrag flow.
In the scenario of no system malloc_size we need to use
zmalloc_usable_size in order to prevent stepping over the
"to-be-replaced" buffer

will partially fix: valkey-io#2435

Signed-off-by: Ran Shidlansik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HFE Fix new test failures

2 participants