Skip to content

Conversation

@ranshid
Copy link
Member

@ranshid ranshid commented May 21, 2025

No special bug or fix, but the way they are defined seems wrong to me

@ranshid ranshid requested review from soloestoy and uriyage May 21, 2025 07:04
@codecov
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.25%. Comparing base (1531b44) to head (a268a8f).
Report is 1 commits behind head on unstable.

Additional details and impacted files
@@            Coverage Diff            @@
##           unstable    #2113   +/-   ##
=========================================
  Coverage     71.24%   71.25%           
=========================================
  Files           122      122           
  Lines         66030    66030           
=========================================
+ Hits          47045    47051    +6     
+ Misses        18985    18979    -6     
Files with missing lines Coverage Δ
src/commands.def 100.00% <ø> (ø)

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ranshid ranshid merged commit 30599c4 into valkey-io:unstable May 21, 2025
52 checks passed
shanwan1 pushed a commit to shanwan1/valkey that referenced this pull request Jun 13, 2025
Should not cause any behavior change, mainly for correctness

Signed-off-by: Ran Shidlansik <[email protected]>
Signed-off-by: shanwan1 <[email protected]>
@uriyage uriyage mentioned this pull request Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants