fix commandlog argument schema to use pure tokens (#2113)

ranshid · web-flow · commit 30599c4936cc · 2025-05-21T13:39:58.000+03:00
Should not cause any behavior change, mainly for correctness 

Signed-off-by: Ran Shidlansik &lt;ranshid@amazon.com&gt;
diff --git a/src/commands.def b/src/commands.def
@@ -6722,9 +6722,9 @@ const char *COMMANDLOG_GET_Tips[] = {
 
 /* COMMANDLOG GET type argument table */
 struct COMMAND_ARG COMMANDLOG_GET_type_Subargs[] = {
-{MAKE_ARG("slow",ARG_TYPE_STRING,-1,NULL,NULL,NULL,CMD_ARG_NONE,0,NULL)},
-{MAKE_ARG("large-request",ARG_TYPE_STRING,-1,NULL,NULL,NULL,CMD_ARG_NONE,0,NULL)},
-{MAKE_ARG("large-reply",ARG_TYPE_STRING,-1,NULL,NULL,NULL,CMD_ARG_NONE,0,NULL)},
+{MAKE_ARG("slow",ARG_TYPE_PURE_TOKEN,-1,"SLOW",NULL,NULL,CMD_ARG_NONE,0,NULL)},
+{MAKE_ARG("large-request",ARG_TYPE_PURE_TOKEN,-1,"LARGE-REQUEST",NULL,NULL,CMD_ARG_NONE,0,NULL)},
+{MAKE_ARG("large-reply",ARG_TYPE_PURE_TOKEN,-1,"LARGE-REPLY",NULL,NULL,CMD_ARG_NONE,0,NULL)},
 };
 
 /* COMMANDLOG GET argument table */
@@ -6773,9 +6773,9 @@ const char *COMMANDLOG_LEN_Tips[] = {
 
 /* COMMANDLOG LEN type argument table */
 struct COMMAND_ARG COMMANDLOG_LEN_type_Subargs[] = {
-{MAKE_ARG("slow",ARG_TYPE_STRING,-1,NULL,NULL,NULL,CMD_ARG_NONE,0,NULL)},
-{MAKE_ARG("large-request",ARG_TYPE_STRING,-1,NULL,NULL,NULL,CMD_ARG_NONE,0,NULL)},
-{MAKE_ARG("large-reply",ARG_TYPE_STRING,-1,NULL,NULL,NULL,CMD_ARG_NONE,0,NULL)},
+{MAKE_ARG("slow",ARG_TYPE_PURE_TOKEN,-1,"SLOW",NULL,NULL,CMD_ARG_NONE,0,NULL)},
+{MAKE_ARG("large-request",ARG_TYPE_PURE_TOKEN,-1,"LARGE-REQUEST",NULL,NULL,CMD_ARG_NONE,0,NULL)},
+{MAKE_ARG("large-reply",ARG_TYPE_PURE_TOKEN,-1,"LARGE-REPLY",NULL,NULL,CMD_ARG_NONE,0,NULL)},
 };
 
 /* COMMANDLOG LEN argument table */
@@ -6805,9 +6805,9 @@ const char *COMMANDLOG_RESET_Tips[] = {
 
 /* COMMANDLOG RESET type argument table */
 struct COMMAND_ARG COMMANDLOG_RESET_type_Subargs[] = {
-{MAKE_ARG("slow",ARG_TYPE_STRING,-1,NULL,NULL,NULL,CMD_ARG_NONE,0,NULL)},
-{MAKE_ARG("large-request",ARG_TYPE_STRING,-1,NULL,NULL,NULL,CMD_ARG_NONE,0,NULL)},
-{MAKE_ARG("large-reply",ARG_TYPE_STRING,-1,NULL,NULL,NULL,CMD_ARG_NONE,0,NULL)},
+{MAKE_ARG("slow",ARG_TYPE_PURE_TOKEN,-1,"SLOW",NULL,NULL,CMD_ARG_NONE,0,NULL)},
+{MAKE_ARG("large-request",ARG_TYPE_PURE_TOKEN,-1,"LARGE-REQUEST",NULL,NULL,CMD_ARG_NONE,0,NULL)},
+{MAKE_ARG("large-reply",ARG_TYPE_PURE_TOKEN,-1,"LARGE-REPLY",NULL,NULL,CMD_ARG_NONE,0,NULL)},
 };
 
 /* COMMANDLOG RESET argument table */
diff --git a/src/commands/commandlog-get.json b/src/commands/commandlog-get.json
@@ -68,18 +68,21 @@
                 "arguments": [
                     {
                         "name": "slow",
-                        "type": "string"
+                        "type": "pure-token",
+                        "token": "slow"
                     },
                     {
                         "name": "large-request",
-                        "type": "string"
+                        "type": "pure-token",
+                        "token": "large-request"
                     },
                     {
                         "name": "large-reply",
-                        "type": "string"
+                        "type": "pure-token",
+                        "token": "large-reply"
                     }
                 ]
             }
         ]
     }
-}
+}
diff --git a/src/commands/commandlog-len.json b/src/commands/commandlog-len.json
@@ -29,18 +29,21 @@
                 "arguments": [
                     {
                         "name": "slow",
-                        "type": "string"
+                        "type": "pure-token",
+                        "token": "slow"
                     },
                     {
                         "name": "large-request",
-                        "type": "string"
+                        "type": "pure-token",
+                        "token": "large-request"
                     },
                     {
                         "name": "large-reply",
-                        "type": "string"
+                        "type": "pure-token",
+                        "token": "large-reply"
                     }
                 ]
             }
         ]
     }
-}
+}
diff --git a/src/commands/commandlog-reset.json b/src/commands/commandlog-reset.json
@@ -26,18 +26,21 @@
                 "arguments": [
                     {
                         "name": "slow",
-                        "type": "string"
+                        "type": "pure-token",
+                        "token": "slow"
                     },
                     {
                         "name": "large-request",
-                        "type": "string"
+                        "type": "pure-token",
+                        "token": "large-request"
                     },
                     {
                         "name": "large-reply",
-                        "type": "string"
+                        "type": "pure-token",
+                        "token": "large-reply"
                     }
                 ]
             }
         ]
     }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -68,18 +68,21 @@`
`68`	`68`	`"arguments": [`
`69`	`69`	`{`
`70`	`70`	`"name": "slow",`
`71`		`- "type": "string"`
	`71`	`+ "type": "pure-token",`
	`72`	`+ "token": "slow"`
`72`	`73`	`},`
`73`	`74`	`{`
`74`	`75`	`"name": "large-request",`
`75`		`- "type": "string"`
	`76`	`+ "type": "pure-token",`
	`77`	`+ "token": "large-request"`
`76`	`78`	`},`
`77`	`79`	`{`
`78`	`80`	`"name": "large-reply",`
`79`		`- "type": "string"`
	`81`	`+ "type": "pure-token",`
	`82`	`+ "token": "large-reply"`
`80`	`83`	`}`
`81`	`84`	`]`
`82`	`85`	`}`
`83`	`86`	`]`
`84`	`87`	`}`
`85`		`-}`
	`88`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -29,18 +29,21 @@`
`29`	`29`	`"arguments": [`
`30`	`30`	`{`
`31`	`31`	`"name": "slow",`
`32`		`- "type": "string"`
	`32`	`+ "type": "pure-token",`
	`33`	`+ "token": "slow"`
`33`	`34`	`},`
`34`	`35`	`{`
`35`	`36`	`"name": "large-request",`
`36`		`- "type": "string"`
	`37`	`+ "type": "pure-token",`
	`38`	`+ "token": "large-request"`
`37`	`39`	`},`
`38`	`40`	`{`
`39`	`41`	`"name": "large-reply",`
`40`		`- "type": "string"`
	`42`	`+ "type": "pure-token",`
	`43`	`+ "token": "large-reply"`
`41`	`44`	`}`
`42`	`45`	`]`
`43`	`46`	`}`
`44`	`47`	`]`
`45`	`48`	`}`
`46`		`-}`
	`49`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -26,18 +26,21 @@`
`26`	`26`	`"arguments": [`
`27`	`27`	`{`
`28`	`28`	`"name": "slow",`
`29`		`- "type": "string"`
	`29`	`+ "type": "pure-token",`
	`30`	`+ "token": "slow"`
`30`	`31`	`},`
`31`	`32`	`{`
`32`	`33`	`"name": "large-request",`
`33`		`- "type": "string"`
	`34`	`+ "type": "pure-token",`
	`35`	`+ "token": "large-request"`
`34`	`36`	`},`
`35`	`37`	`{`
`36`	`38`	`"name": "large-reply",`
`37`		`- "type": "string"`
	`39`	`+ "type": "pure-token",`
	`40`	`+ "token": "large-reply"`
`38`	`41`	`}`
`39`	`42`	`]`
`40`	`43`	`}`
`41`	`44`	`]`
`42`	`45`	`}`
`43`		`-}`
	`46`	`+}`