Skip to content

check more special characters when validating a FQDN #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
profnandaa merged 1 commit into from
Oct 30, 2021
Merged

check more special characters when validating a FQDN #1799

profnandaa merged 1 commit into from
Oct 30, 2021

Conversation

@MatteoPierro
Copy link
Contributor

@MatteoPierro MatteoPierro commented Oct 17, 2021

This PR allows to detect a FQDN as invalid when containing characters of one of these UTF-8 blocks:

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 17, 2021

Codecov Report

Merging #1799 (284276c) into master (4ec30b7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1799   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2029      2029           
  Branches       457       457           
=========================================
  Hits          2029      2029
Impacted Files Coverage Δ
src/lib/isFQDN.js 100.00% <100.00%> (ø)
src/lib/isURL.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ec30b7...284276c. Read the comment docs.

@MatteoPierro
Copy link
Contributor Author

MatteoPierro commented Oct 17, 2021

This should also close the issue #1087

@MatteoPierro
Copy link
Contributor Author

MatteoPierro commented Oct 18, 2021

Ei @tux-tn Can I have your feedback about this? 😇

@tux-tn
Copy link
Member

tux-tn commented Oct 18, 2021

@MatteoPierro Yes sir! i'm reviewing some pending PRs, i will probably check yours today! Thank you

tux-tn
tux-tn approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thank you for your PR @MatteoPierro

@tux-tn tux-tn added the ready-to-land For PRs that are reviewed and ready to be landed label Oct 19, 2021
@MatteoPierro
Copy link
Contributor Author

MatteoPierro commented Oct 19, 2021

May I ask if you can add the label hacktoberfest-accepted ? 👀

@tux-tn
Copy link
Member

tux-tn commented Oct 19, 2021

May I ask if you can add the label hacktoberfest-accepted ? 👀

Done 😃

profnandaa
profnandaa approved these changes Oct 30, 2021
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🎉

@profnandaa profnandaa merged commit 6eed6a4 into validatorjs:master Oct 30, 2021
theteladras pushed a commit to theteladras/validator.js that referenced this pull request Oct 30, 2021
@MatteoPierro @theteladras
fix(isFQDN): check more special chars (validatorjs#1799)
f8d0de7 
fixes validatorjs#1087
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
@MatteoPierro @profnandaa
fix(isFQDN): check more special chars (#1799)
1d2809f 
fixes #1087
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
@MatteoPierro @profnandaa
fix(isFQDN): check more special chars (#1799)
6a3684e 
fixes #1087
@profnandaa profnandaa mentioned this pull request Oct 31, 2021
Closed
@deltoro05
Copy link

deltoro05 commented Jun 6, 2024

This URL https://unicode-table.com/ has changed to https://symbl.cc/

This PR allows to detect a FQDN as invalid when containing characters of one of these UTF-8 blocks:

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@profnandaa profnandaa profnandaa approved these changes

@tux-tn tux-tn tux-tn approved these changes

Assignees

No one assigned

Labels

hacktoberfest-accepted ready-to-land For PRs that are reviewed and ready to be landed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MatteoPierro @tux-tn @deltoro05 @profnandaa