fix(isFQDN): check more special chars (#1799)

MatteoPierro · web-flow · commit 6eed6a4ec8dc · 2021-10-30T09:52:35.000+03:00
fixes #1087
diff --git a/src/lib/isFQDN.js b/src/lib/isFQDN.js
@@ -32,12 +32,12 @@ export default function isFQDN(str, options) {
       return false;
     }
 
-    if (!/^([a-z\u00a1-\uffff]{2,}|xn[a-z0-9-]{2,})$/i.test(tld)) {
+    if (!/^([a-z\u00A1-\u00A8\u00AA-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF]{2,}|xn[a-z0-9-]{2,})$/i.test(tld)) {
       return false;
     }
 
-    // disallow spaces && special characers
-    if (/[\s\u2002-\u200B\u202F\u205F\u3000\uFEFF\uDB40\uDC20\u00A9\uFFFD]/.test(tld)) {
+    // disallow spaces
+    if (/\s/.test(tld)) {
       return false;
     }
   }
diff --git a/test/validators.js b/test/validators.js
@@ -1099,6 +1099,18 @@ describe('Validators', () => {
         'domain.com/',
         '/more.com',
         'domain.com�',
+        'domain.co\u00A0m',
+        'domain.co\u1680m',
+        'domain.co\u2006m',
+        'domain.co\u2028m',
+        'domain.co\u2029m',
+        'domain.co\u202Fm',
+        'domain.co\u205Fm',
+        'domain.co\u3000m',
+        'domain.com\uDC00',
+        'domain.co\uEFFFm',
+        'domain.co\uFDDAm',
+        'domain.co\uFFF4m',
         'domain.com©',
         'example.0',
         '192.168.0.9999',

Original file line number	Diff line number	Diff line change
`@@ -32,12 +32,12 @@ export default function isFQDN(str, options) {`
`32`	`32`	`return false;`
`33`	`33`	`}`
`34`	`34`
`35`		`- if (!/^([a-z\u00a1-\uffff]{2,}\|xn[a-z0-9-]{2,})$/i.test(tld)) {`
	`35`	`+ if (!/^([a-z\u00A1-\u00A8\u00AA-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF]{2,}\|xn[a-z0-9-]{2,})$/i.test(tld)) {`
`36`	`36`	`return false;`
`37`	`37`	`}`
`38`	`38`
`39`		`- // disallow spaces && special characers`
`40`		`- if (/[\s\u2002-\u200B\u202F\u205F\u3000\uFEFF\uDB40\uDC20\u00A9\uFFFD]/.test(tld)) {`
	`39`	`+ // disallow spaces`
	`40`	`+ if (/\s/.test(tld)) {`
`41`	`41`	`return false;`
`42`	`42`	`}`
`43`	`43`	`}`