validator to check if strong password exists #1149
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please clean up this PR to only include the relevant files needed for the feature work. |
profnandaa
added
the
🧹 needs-update
tux-tn
reviewed
Oct 14, 2019
Member
tux-tn
left a comment
tux-tn
left a comment
There was a problem hiding this comment.
Hello @MohakChugh , i suggest you to read Contributing guidelines
- You pushed a
.historyfolder with 131 files, you need to delete that folder - You added your changes to
/libfolder which is autogenerated, you need instead to usesrc/lib - You need to add tests to your changes and a section in
README.mdif you are adding a new validator
Author
|
I removed the History and Deleted the file from lib folder. Sorry for not following the guidelines earlier |
Member
|
Can fix the merge conflicts? |
profnandaa
requested changes
Dec 6, 2019
Member
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
Please redo this PR afresh, looks like to removed the important source file.
Member
|
closing for #1148 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new Validator which checks if the password provided is a strong password or not.
A password is a strong password is it contains :