Validate strong Password by validate_password.js #1148
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Clean this up. |
profnandaa
added
the
🧹 needs-update
Author
|
Can you provide more details on it |
Author
|
did some cleanup and added a commit . Can u review and comment on it? |
profnandaa
requested changes
Dec 6, 2019
Member
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
Please clean up this PR, so many unrelated changes in the diff.
profnandaa
requested changes
Mar 22, 2020
Member
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
@gayathrigs27
Thanks for your contribution! 🎉 Could you please remove any unrelated changes?
I have a few comments below.
| export default function validatePassword(str) { | ||
| const format = /[ !@#$%^&*()_+\-=\[\]{};':"\\|,.<>\/?]/; | ||
| assertString(str); | ||
| return (/[a-z]/.test(str)) && (/[A-Z]/.test(str)) && (/[\d]/.test(str)) && format.test(str); |
Member
There was a problem hiding this comment.
This looks good.
Few suggestions:
- Perhaps we
minLengthparameter? - Can rename this validator to
isStrongPassword
Member
|
Closing in favor of newer PR raised #1348 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.