Skip to content

Use Lwt.reraise over Lwt.fail #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reynir wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use Lwt.reraise over Lwt.fail #594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a594fa2
Use Lwt.reraise over Lwt.fail
reynir Jan 16, 2026
67e42b7
Require lwt>=5.7.0 in dune-project
reynir Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dune-project
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
(>= 4.0.0)
(< 5.0.0)))
(lwt
(>= 5.6.1))
(>= 5.7.0))
(logs
(>= 0.7.0))
(containers
Expand Down
2 changes: 1 addition & 1 deletion pool.opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ depends: [
"sihl" {>= "4.0.0" & < "5.0.0"}
"sihl-email" {>= "4.0.0" & < "5.0.0"}
"sihl-storage" {>= "4.0.0" & < "5.0.0"}
"lwt" {>= "5.6.1"}
"lwt" {>= "5.7.0"}
"logs" {>= "0.7.0"}
"containers" {>= "3.14"}
"containers-data" {>= "3.14"}
Expand Down
2 changes: 1 addition & 1 deletion pool/database/pools.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ module Make (Config : Pools_sig.ConfigSig) = struct
Logs.debug (fun m -> m "Successfully rolled back transaction"))
|> Pool.raise_caqti_error label
in
Lwt.fail error
Copy link
Collaborator Author

@reynir reynir Jan 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% certain about this one. Specifically, I'm not sure what happens if the exception passed to rollback wasn't raised and if that could cause issues. However, the function is not exported in the interface and it is only called inside a Lwt.catch so it should be fine as it is now.

Updated: in the top level it seems to act like raise...

Lwt.reraise error
;;

let transaction
Expand Down
2 changes: 1 addition & 1 deletion pool/web/middleware/middleware_logger.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ let logger =
(fun exn ->
Logs.err ~src (fun m -> m ~tags "%s" (Exn.to_string exn));
Logs.err ~src (fun m -> m ~tags "%s" (Printexc.get_backtrace ()));
Lwt.fail exn)
Lwt.reraise exn)
in
Rock.Middleware.create ~name:"Logger" ~filter
;;