Conversation
Lwt.reraise preserves backtraces
We already have that constraint in esy.json.
reynir
commented
Jan 16, 2026
| Logs.debug (fun m -> m "Successfully rolled back transaction")) | ||
| |> Pool.raise_caqti_error label | ||
| in | ||
| Lwt.fail error |
Collaborator
Author
There was a problem hiding this comment.
I'm not 100% certain about this one. Specifically, I'm not sure what happens if the exception passed to rollback wasn't raised and if that could cause issues. However, the function is not exported in the interface and it is only called inside a Lwt.catch so it should be fine as it is now.
Updated: in the top level it seems to act like raise...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lwt.reraisepreserves backtraces whileLwt.faildoesn't.Available since lwt.5.7.0. We already had that requirement in esy.json but not in
dune-project/pool.opam-pool.opam.lockedis at a much more recent version.https://github.com/ocsigen/lwt/blob/4714cea1b73aaccf1ea2ea2a18db565070ca680c/CHANGES#L129