Skip to content

MAINT: Deselect more test instances failing from known KMeans bug #2795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 28, 2025
Merged

MAINT: Deselect more test instances failing from known KMeans bug #2795

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a167c69
deselect more instances of the same bug
david-cortes-intel Nov 24, 2025
8028345
Merge branch 'main' into km_known_bug
david-cortes-intel Nov 26, 2025
76d391e
Merge branch 'main' into km_known_bug
david-cortes-intel Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deselected_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,8 +322,8 @@ deselected_tests:
- cluster/tests/test_k_means.py::test_kmeans_elkan_results[0-sparse
# Temporary deselections due to a bug in oneDAL, remove once the issue is fixed.
# Probably can also removed the kmeans ones above once these are fixed.
- cluster/tests/test_k_means.py::test_float_precision[42-KMeans-sparse_matrix]
- cluster/tests/test_k_means.py::test_float_precision[42-KMeans-sparse_array]
Copy link
Contributor

@ethanglaser ethanglaser Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the issue with sparse and dense arrays? Because unless this is a sparse only test, deselecting test_float_precision entirely would skip running on dense as well

Copy link
Contributor Author

@david-cortes-intel david-cortes-intel Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's now affecting both, but dense one much less frequently than sparse.

- cluster/tests/test_k_means.py::test_float_precision
- cluster/tests/test_k_means.py::test_kmeans_relocated_clusters
- cluster/tests/test_kmeans.py::test_dense_vs_sparse[dims0-elkan-k-means++-None]
- cluster/tests/test_kmeans.py::test_dense_vs_sparse[dims1-full-k-means++-None]
- cluster/tests/test_kmeans.py::test_dense_vs_sparse[dims2-full-k-means++-None]
Expand Down
Loading