MAINT: Deselect more test instances failing from known KMeans bug #2795
Conversation
david-cortes-intel
requested review from
ahuber21,
ethanglaser,
icfaust and
yuejiaointel
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| # Temporary deselections due to a bug in oneDAL, remove once the issue is fixed. | ||
| # Probably can also removed the kmeans ones above once these are fixed. | ||
| - cluster/tests/test_k_means.py::test_float_precision[42-KMeans-sparse_matrix] | ||
| - cluster/tests/test_k_means.py::test_float_precision[42-KMeans-sparse_array] |
There was a problem hiding this comment.
Is the issue with sparse and dense arrays? Because unless this is a sparse only test, deselecting test_float_precision entirely would skip running on dense as well
There was a problem hiding this comment.
Looks like it's now affecting both, but dense one much less frequently than sparse.
|
/intelci: run |
Vika-F
left a comment
Vika-F
left a comment
There was a problem hiding this comment.
Let's wait for the Pre-Commit results showing no failures in test_k_means and LGTM.
@Vika-F The failures that this aims to solve are in the azure pipelines. |
|
@david-cortes-intel Ok, then I'll cancel the Pre-Commit job, and you can merge. |
david-cortes-intel
merged commit 7d7873a
into
uxlfoundation:main
3 participants
Description
Adds more temporary deselections of conformance tests that all fail from the same known bug in oneDAL which is still being investigated.
Checklist:
Completeness and readability
Testing