Improve syntax for ink! e2e runtime_only attribute argument#2083
Merged
ascjones merged 2 commits intouse-ink:masterfrom Jan 30, 2024
davidsemakula:e2e-runtime-only-arg-syntax
Merged
Improve syntax for ink! e2e runtime_only attribute argument#2083ascjones merged 2 commits intouse-ink:masterfrom davidsemakula:e2e-runtime-only-arg-syntax
runtime_only attribute argument#2083ascjones merged 2 commits intouse-ink:masterfrom
davidsemakula:e2e-runtime-only-arg-syntax
Conversation
Use `#[darling(word)]` to enable writing `#[ink_e2e::test(backend(runtime_only))]` instead of `#[ink_e2e::test(backend(runtime_only()))]`
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2083 +/- ##
==========================================
- Coverage 53.70% 53.69% -0.01%
==========================================
Files 223 223
Lines 7040 7043 +3
Branches 3141 3121 -20
==========================================
+ Hits 3781 3782 +1
- Misses 3259 3261 +2 ☔ View full report in Codecov by Sentry. |
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the
Link to the run | Last update: Tue Jan 30 05:45:51 CET 2024 |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #_
cargo-contractorpallet-contracts?Use
#[darling(word)]to enable writing#[ink_e2e::test(backend(runtime_only))]instead of#[ink_e2e::test(backend(runtime_only()))]Description
runtime_onlyattribute argument by using#[darling(word)]to enable writing#[ink_e2e::test(backend(runtime_only))]instead of#[ink_e2e::test(backend(runtime_only()))]See TedDriggs/darling#260 and https://github.com/TedDriggs/darling/blob/master/examples/heterogeneous_enum_and_word.rs for details.
Checklist before requesting a review
CHANGELOG.md