Improve FromMeta implementation for enums

[davidsemakula]

Improves FromMeta implementation for enums

• Properly implement unit arms in FromMeta::from_list to provide a consistent API for heterogenous enums that include a mix of unit, newtype and struct variants (see included test for an example).
• Add #[darling(word)] for unit enum variants (See Add #[darling(word)] for enum variants #63).
• Adds tests for behavior of FromMeta implementation for enums.

[davidsemakula]

I'm working on implementing support for #[darling(word)] syntax

[TedDriggs]

I am very excited about where this is heading; thank you for the latest updates. Feedback is now starting to get more specific, so I think we're closing in on readiness to merge.

[davidsemakula]

LMK if I should squash the commits 🙂

[TedDriggs]

The only remaining items are:

1. Deciding if this is the best name for this attribute. I thought it was originally (and I still don't think default is appropriate), but I am now worrying that word is too cryptic.
2. Updating the CHANGELOG
3. Updating the README

[TedDriggs]

LMK if I should squash the commits 🙂

I think we're very close to the squash point.

[davidsemakula]

I'll work on the changelog and readme updates tomorrow.

1. Deciding if this is the best name for this attribute. I thought it was originally (and I still don't think default is appropriate), but I am now worrying that word is too cryptic.

Agreed, default would be confusing and word is a bit cryptic, but I don't have a better suggestion at this point. May be the more verbose from_word?

[davidsemakula]

I updated the changelog. But I don't think I can update the readme to introduce and describe #[darling(word)] succinctly, can you take that part? I'm guessing it should be a bullet point under Features?

[TedDriggs]

In the absence of a README entry, we could consider an example that includes several features of a heterogeneous enum. Maybe replicate one of the tests over to the examples and add some comments to show what's going on?

[davidsemakula]

Sounds good, I'll work on an example 👍

[davidsemakula]

In the absence of a README entry, we could consider an example that includes several features of a heterogeneous enum. Maybe replicate one of the tests over to the examples and add some comments to show what's going on?

Added an example.

[davidsemakula]

Pinging @TedDriggs

[TedDriggs]

Very minor changes left, then we're ready to merge!

Apologies for the delayed review, I was traveling last week and getting caught up at work this week.

[davidsemakula]

@TedDriggs can we get this published on crates.io when you have some time?
If I can do anything to help that process along, LMK 🙂

[TedDriggs]

Will do on Monday; out of town this weekend

…

________________________________ From: David Semakula ***@***.***> Sent: Thursday, January 25, 2024 11:13:50 AM To: TedDriggs/darling ***@***.***> Cc: Ted Driggs ***@***.***>; Mention ***@***.***> Subject: Re: [TedDriggs/darling] Improve `FromMeta` implementation for enums (PR #260) @TedDriggs<https://github.com/TedDriggs> can we get this published on crates.io when you have some time? If I can do anything to help that process along, LMK 🙂 — Reply to this email directly, view it on GitHub<#260 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABEVHRZWVZUL6IB6CGXY5STYQKVG5AVCNFSM6AAAAABBFFQZJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJQHAZDKNZRGY>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[TedDriggs]

v0.20.4 is now live.

[davidsemakula]

Awesome! Thanks for taking the time to review this PR 🙂