Merged
Conversation
HCastano
force-pushed
the
v4.0.0-beta
branch
from
cceedc3 to
476e804
Compare
Codecov Report
@@ Coverage Diff @@
## master #1508 +/- ##
==========================================
+ Coverage 64.55% 71.69% +7.13%
==========================================
Files 204 204
Lines 6314 6316 +2
==========================================
+ Hits 4076 4528 +452
+ Misses 2238 1788 -450
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Looks like we need to wait on a `smart-bench` release to be published before we can publish the E2E testing crate.
Contributor
|
During this I realized that the E2E testing framework is using a Git dep of |
SkymanOne
approved these changes
Nov 22, 2022
| of the newly added `LangError`. | ||
|
|
||
| In short, this change means that all ink! messages and constructors now return a | ||
| `Result<R, LangError>`, where `R` is the original return type. Contract callers can |
Contributor
There was a problem hiding this comment.
Would be nice to specify that for constructors R can also be Result<Self, Error> which will result in Result<Result<Self, Error>, LangError>
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Result<Self, Error>as a return type in constructors ‒ #1446Mapping::take()function allowing to get a value removing it from storage ‒ #1461Changed
LangError) ‒ #1450LangErrors from constructors ‒ #1504scale-inforequirement to2.3‒ #1467Mapping::insert(key, val)andMapping::insert_return_size(key, val)into one method - #1463Removed
ink_env::randomfunction ‒ #1442Closes #1478.
Post release:
cargo-contractcompanion release (update template) Releasev2.0.0-betacargo-contract#828