Replace Mapping::insert_return_size with Mapping::insert#1463
Merged
Replace Mapping::insert_return_size with Mapping::insert#1463
Mapping::insert_return_size with Mapping::insert#1463Conversation
lean-apple
requested review from
HCastano,
ascjones and
cmichi
as code owners
ascjones
reviewed
Nov 3, 2022
Collaborator
Please give more context in the PR description e.g. "we added a new method to make it non-breaking, now we are doing 4.0 so we can make the breaking change" (it's what I assume the reasoning to be). Also links to relevant PRs are useful #1224 |
Codecov Report
@@ Coverage Diff @@
## master #1463 +/- ##
===========================================
+ Coverage 46.97% 63.96% +16.98%
===========================================
Files 201 201
Lines 6210 6210
===========================================
+ Hits 2917 3972 +1055
+ Misses 3293 2238 -1055
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ascjones
approved these changes
Nov 4, 2022
Collaborator
ascjones
left a comment
ascjones
left a comment
There was a problem hiding this comment.
LGTM, Please add this to the Unreleased section of CHANGELOG.md before merging
ascjones
reviewed
Nov 7, 2022
HCastano
approved these changes
Nov 7, 2022
CHANGELOG.md
Outdated
|
|
||
| ### Removed | ||
| - Remove `ink_env::random` function ‒ [#1442](https://github.com/paritytech/ink/pull/1442) | ||
| - Remove previous insert `Mapping::insert(key, val)` method and replace by `Mapping::insert_return_size(key, val)` behaviour but under the same method name insert - [#1463](https://github.com/paritytech/ink/pull/1463) |
Contributor
There was a problem hiding this comment.
Can you wrap this to ~100 chars?
| /// Returns the size of the pre-existing value at the specified key if any. | ||
| #[inline] | ||
| pub fn insert_return_size<Q, R>(&mut self, key: Q, value: &R) -> Option<u32> | ||
| pub fn insert<Q, R>(&mut self, key: Q, value: &R) -> Option<u32> |
Contributor
There was a problem hiding this comment.
In the docs can you also specify the returned size is in bytes?
HCastano
changed the title
Mapping::insert_return_size with Mapping::insert
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the wake of this last change #1224 (comment) where Mapping::insert_return_size was added to make it non-breaking, this method would replace the current insert one for the release 4.0.
More precisely, the method
fn Mapping::insert_return_size(key, val) -> Option<u32>;was merged into the methodfn Mapping::insert(key, val);