Skip to content

fix: Skip binary names in docker builds #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cmichi merged 1 commit into from
Nov 30, 2025
Merged

fix: Skip binary names in docker builds #2172

cmichi merged 1 commit into from
Nov 30, 2025

Conversation

@tsenovilla
Copy link
Contributor

@tsenovilla tsenovilla commented Nov 26, 2025 •
edited
Loading

Small PR to allow verifiable builds from CLIs that are not the cargo contract one. Right now the docker build captures the binary name as an argument and use it as a cargo contract argument inside the container.

@tsenovilla tsenovilla mentioned this pull request Nov 27, 2025
Merged
@cmichi cmichi merged commit ceb7b89 into master Nov 30, 2025
17 checks passed
@cmichi cmichi deleted the fix/skip-binary-names-in-docker-builds branch November 30, 2025 22:03
@tsenovilla tsenovilla mentioned this pull request Dec 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmichi cmichi cmichi approved these changes

@davidsemakula davidsemakula Awaiting requested review from davidsemakula davidsemakula is a code owner

@AlexD10S AlexD10S Awaiting requested review from AlexD10S AlexD10S is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tsenovilla @cmichi