fix(binding): Avoid reading source property on UpdateSource for non-DP (backport #13698 and #13521 and #13700)#13728
Merged
jeromelaban merged 11 commits intolegacy/4xfrom Sep 21, 2023
Merged
Conversation
6 tasks
Contributor
|
The build 94877 found UI Test snapshots differences: Details
|
`WindowsAppSDKWinUI` has been removed in 1.4, using `UseWinUITools` until we can find a more stable property. (cherry picked from commit 85a5aae)
(cherry picked from commit 472df6c)
(cherry picked from commit 1d89227)
(cherry picked from commit 3f40f06) # Conflicts: # build/PackageDiffIgnore.xml
.NET 8 changes the ordering of nuget defined props files, This change makes WinUI detection independent of nuget props import and rely on .targets evaluation.
github-actions
bot
added
area/code-generation
jeromelaban
changed the title
nickrandolph
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #13698 and #13521 and #13700
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com