fix(net8): Adjust WinUI property detection#13700
Merged
jeromelaban merged 1 commit intomasterfrom Sep 20, 2023
Merged
Conversation
.NET 8 changes the ordering of nuget defined props files, This change makes WinUI detection independent of nuget props import and rely on .targets evaluation.
github-actions
bot
added
the
area/build
Contributor
|
The build 94727 found UI Test snapshots differences: Details
|
MartinZikmund
approved these changes
Sep 20, 2023
Contributor
|
@jeromelaban does this need a backport? |
|
@jeromelaban How can I use this fix, I tried to install preview packages but I got the same error. |
Member
Author
|
@tibitoth this has been release in the latest build of 4.10.x. If you're still having issues, make sure to open a discussion. |
Contributor
@jeromelaban, I apologize for asking, but what about version 5.0.0-dev.****? |
Member
Author
|
@limeniye can you open a discussion with more details, this is already on 5.0-dev builds. Thanks! |
Contributor
|
My bad. Was successfully fixed. Off topI confused it with the RuntimeIdentifiers problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #13678
PR Type
What kind of change does this PR introduce?
What is the new behavior?
.NET 8 changes the ordering of nuget defined props files, This change makes WinUI detection independent of nuget props import and rely on .targets evaluation.
Copilot Summary
🤖 Generated by Copilot at 591797b
Moved the import of
uno.winui.common.propsto the targets file and added a check for WinAppSDK projects. This fixes a bug where WinUI projects using WinAppSDK were not recognized by Uno.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):