[UNDERTOW-2693] The ServletCookieAdaptor handles the isSameSite() and setSameSite() incorrectly#1908
Merged
Merged
Conversation
… if a value has been set in the cookie. Setting a Lax value to the mode when set to true was wrong, so we need to revert this part. https://issues.redhat.com/browse/UNDERTOW-2693 Signed-off-by: James R. Perkins <jperkins@ibm.com>
…e is set. This restores the original behavior. https://issues.redhat.com/browse/UNDERTOW-2693 Signed-off-by: James R. Perkins <jperkins@ibm.com>
fl4via
added
bug fix
This was referenced Feb 18, 2026
fl4via
changed the title
fl4via
removed
the
next release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira:
https://issues.redhat.com/browse/UNDERTOW-2693
2.3.x PRs: #1890 #1891
Undertow EE PRs:
Main: undertow-io/undertow-ee#43
1.0.x: undertow-io/undertow-ee#65