[UNDERTOW-2693] Use a boolean for the isSameSite rather than checking…#43
Merged
Conversation
Contributor
|
LGTM: though does this change is only scoped to this part? We have sort of a bit of repetition when it comes to this. So it might warrant a change in other places? |
ropalka
approved these changes
Feb 7, 2026
… if a value has been set in the cookie. Setting a Lax value to the mode when set to true was wrong, so we need to revert this part. https://issues.redhat.com/browse/UNDERTOW-2693 Signed-off-by: James R. Perkins <[email protected]>
Member
You are right. Can you please create a Jira for this? And assign it to the next Beta @baranowb ? |
fl4via
added
bug fix
Member
This was referenced Feb 20, 2026
fl4via
removed
the
next release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… if a value has been set in the cookie. Setting a Lax value to the mode when set to true was wrong, so we need to revert this part.
https://issues.redhat.com/browse/UNDERTOW-2693
Undertow PRs:
2.3.x: undertow-io/undertow#1890 undertow-io/undertow#1891
EE 1.0.x PR: #65