Localization: Restores region-specific cultures#20939
Merged
iOvergaard merged 4 commits intorelease/17.0from Nov 24, 2025
Merged
Localization: Restores region-specific cultures#20939iOvergaard merged 4 commits intorelease/17.0from
iOvergaard merged 4 commits intorelease/17.0from
Conversation
This is to support backwards-compatibility and v13 upgradability.
since it duplicated the English fallback texts.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores region-specific culture variants (e.g., cs-CZ, da-DK, de-DE) to ensure backwards compatibility with Umbraco v13 and support upgradability to v17. The region-specific cultures are added as extension manifests without localization files, falling back to their base language localizations.
Key Changes:
- Added 25 region-specific culture manifest entries for languages that had region variants in v13
- Removed the
weightproperty from all localization manifests and consolidated themetaproperty formatting - Updated the
uiCulturesection inen.tsto include display names for all region-specific cultures - Removed the
uiCulturesection fromvi.ts(likely centralized toen.ts)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Umbraco.Web.UI.Client/src/packages/core/localization/manifests.ts |
Added 25 region-specific culture manifests (without JS imports) and reformatted all entries to remove weight and consolidate meta properties |
src/Umbraco.Web.UI.Client/src/assets/lang/en.ts |
Added localized display names for all region-specific cultures in the uiCulture section, improved some existing language names (Hebrew, Romanian), and reformatted some long strings |
src/Umbraco.Web.UI.Client/src/assets/lang/vi.ts |
Removed the uiCulture section (centralized to English base localization) |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
iOvergaard
approved these changes
Nov 24, 2025
iOvergaard
pushed a commit
that referenced
this pull request
Nov 24, 2025
* Adds localization manifests for region-specific cultures This is to support backwards-compatibility and v13 upgradability. * Removed `uiCulture` from Vietnamese localizations since it duplicated the English fallback texts. * 'en' localization file formatting * Update src/Umbraco.Web.UI.Client/src/assets/lang/en.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
leekelleher
added a commit
that referenced
this pull request
Nov 24, 2025
* Adds localization manifests for region-specific cultures This is to support backwards-compatibility and v13 upgradability. * Removed `uiCulture` from Vietnamese localizations since it duplicated the English fallback texts. * 'en' localization file formatting * Update src/Umbraco.Web.UI.Client/src/assets/lang/en.ts --------- Co-authored-by: Lee Kelleher <leekelleher@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
This pull request has been mentioned on Umbraco community forum. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to be backwards-compatible and support v13 upgradability (to v17), this pull request restores the region-specific cultures (that existed in v13).
These region-specific cultures have been added as extension manifests only, they do not have any localization entries; as they will fallback on their non-region-specific (base) language localization entries.
Note
To note, I have removed the
weightproperty, since the default weight for alocalizationextension is already100.Also, I have removed the
uiCulturessection from the Vietnamese localization, as they duplicated English (fallback).How to test?
Go to the user detail screen, see the UI Culture dropdown field, does it contain options for each language with/without region?