Skip to content

Tiptap RTE: Adds accessibility attributes for RTE input #20157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leekelleher merged 9 commits into from
Sep 17, 2025
Merged

Tiptap RTE: Adds accessibility attributes for RTE input #20157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
84dc07c
Add Accessibility for RTE input fields
Sep 16, 2025
55d905e
fix indentation
Sep 16, 2025
5360df9
update method with singular fetch
Sep 16, 2025
e71693c
Update misleading profile button label and localizations
Sep 16, 2025
afb468c
Revert "Update misleading profile button label and localizations"
Sep 16, 2025
6d9018c
simplify the call and make fallback to EN localization
Sep 17, 2025
caaf57e
add localization key for EN
Sep 17, 2025
889b8ed
Whitespace tidy-up
leekelleher Sep 17, 2025
443c5ca
Adds `aria-required` attribute
leekelleher Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Umbraco.Web.UI.Client/src/assets/lang/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2773,6 +2773,7 @@ export default {
wordWrapConfigDescription: 'Enable word wrapping in the code editor.',
},
rte: {
label: 'Rich Text Editor',
config_blocks: 'Available Blocks',
config_blocks_description: 'Define the available blocks.',
config_ignoreUserStartNodes: 'Ignore User Start Nodes',
Expand Down
7 changes: 6 additions & 1 deletion ...Umbraco.Web.UI.Client/src/packages/tiptap/components/input-tiptap/input-tiptap.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,12 @@
this._editor = new Editor({
element: element,
editable: !this.readonly,
editorProps: { attributes: { 'aria-label': this.label ?? 'Rich Text Editor' } },
editorProps: {
attributes: {
'aria-label': this.label || this.localize.term('rte_label'),
'aria-required': this.required ? 'true' : 'false',
},
},

Check warning on line 181 in src/Umbraco.Web.UI.Client/src/packages/tiptap/components/input-tiptap/input-tiptap.element.ts

View check run for this annotation

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

UmbInputTiptapElement.loadEditor increases in cyclomatic complexity from 13 to 15, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
extensions: tiptapExtensions,
content: this.#value,
injectCSS: false, // Prevents injecting CSS into `window.document`, as it never applies to the shadow DOM. [LK]
Expand Down
Loading