Skip to content

Tiptap RTE: Adds accessibility attributes for RTE input #20157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leekelleher merged 9 commits into from
Sep 17, 2025

Adds `aria-required` attribute

443c5ca
Select commit
Loading
Failed to load commit list.
Merged

Tiptap RTE: Adds accessibility attributes for RTE input #20157

Adds `aria-required` attribute
443c5ca
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Sep 17, 2025 in 50s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Prevent hotspot decline (1 hotspot with Complex Method)
Enforce advisory code health rules (1 file with Complex Method)

Gates Passed
2 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Prevent hotspot decline Violations Code Health Impact
input-tiptap.element.ts 1 rule in this hotspot 9.05 → 9.00 Suppress
Enforce advisory code health rules Violations Code Health Impact
input-tiptap.element.ts 1 advisory rule 9.05 → 9.00 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method input-tiptap.element.ts: UmbInputTiptapElement.loadEditor 🔥

Annotations

Check warning on line 181 in src/Umbraco.Web.UI.Client/src/packages/tiptap/components/input-tiptap/input-tiptap.element.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

UmbInputTiptapElement.loadEditor increases in cyclomatic complexity from 13 to 15, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis